Modifies first-ad-paint audit to use impression ping. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r event, this is to account for complications encountered with OOP IFrames. Shifts scoring metrics by -300 ms to account for differences in observed metrics.
Merged
Closed
jonkeller
approved these changes
Sep 6, 2019
warrengm
approved these changes
Sep 9, 2019
Contributor
warrengm
left a comment
warrengm
left a comment
There was a problem hiding this comment.
Approved with a suggestion for a follow-up PR
| // limitations under the License. | ||
|
|
||
| const AdPaintTime = require('../computed/ad-paint-time'); | ||
| const ComputedAdPaintTime = require('../computed/ad-paint-time'); |
Contributor
There was a problem hiding this comment.
Can we rename "ad paint" to "ad render" in a future PR? It's not really accurate after this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies first-ad-paint audit to use impression ping instead of render event, this is to account for complications encountered with OOP IFrames.
Shifts scoring metrics by -300 ms to account for differences in observed metrics.
This is in preparation for GoogleChrome/lighthouse#8979