Update url-shortner.php #1439
Update url-shortner.php #1439
Conversation
Who write this Code? No Exception Handling, no validation. Don't use short opener for examples. php.ini is not unique configured! Add simple HTML-Required-Attr.
googlebot
added
the
cla: yes
| <a class='login' href='<?php echo $authUrl; ?>'>Connect Me!</a> | ||
| </div> | ||
| <?php elseif (empty($short)): ?> | ||
| <form id="url" method="POST" action="<?= htmlspecialchars($_SERVER['PHP_SELF']); ?>"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <input type="hidden" name="csrf_token" value="<?php echo getCsrfToken() ?>" /> | ||
| <input type="submit" value="Shorten"> | ||
| </form> | ||
| <form id="logout" method="POST" action="<?= htmlspecialchars($_SERVER['PHP_SELF']); ?>"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
The Project is full of Short-Tags. I would start to fix it and rebuild the project, but im not sure if this a good idea, because we must rebuild a lot of things! What did you say? If you promise that the project will not be finished now, I will develop it until i die! :D |
|
@Assimilationstheorie I don't disagree. How do you want to proceed? Do you want to make another change on this PR and merge this first? or Do you want to file another issue and wait for us to fix them? |
|
No Issue, i fix it self. I make another PR and start this week with fix all other files. Okay? :) |
|
Hello, I am sorry you are not happy with the samples. But it is not necessary to remove short tags. They are 100% okay. You may be confusing them with these tags: As this repo is marked as supported for PHP 5.4 and above, I do not want to change the short tags. I see that you are also adding a placeholder for the URL, and a |
|
Hey @bshaffer Short PHP-Tags are configured in php.ini -> "short_open_tag". Any Configuration in this File are unique and not the same for all people. When you use the "long tag", this will work on all configurations because thats the "default way". We eliminate a potential Error! :) |
|
@Assimilationstheorie thank you for your concern but the |
|
@Assimilationstheorie additionally, there is a version of this library ( |
4 participants
Who write this Code? No Exception Handling, no Validation.
Don't use short opener for examples. php.ini is not unique configured!
Add simple HTML-Required-Attr.