-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore: Add conventional commits to PR body of discovery document update #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nt into add-conventional-commits-to-pr-body
e0e4ffe to
c1e8ede
Compare
|
@busunkim96 @tswast PTAL |
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray for better test coverage!
I see from the tests that feat(bigquery) is coming from the summary column, but I don't see in this PR where that is happening. Was it always in the summary and we're just including that in the PR body now?
Correct! It's already included in the summary. The reason that I included it previously was because I also used conventional commit messages in the individual commits for each API. For example, see this commit which has a commit message that begins with |
|
@busunkim96 PTAL |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1313 🦕