Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Apr 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1313 🦕

@parthea parthea requested a review from a team as a code owner April 25, 2021 16:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2021
@parthea parthea force-pushed the add-conventional-commits-to-pr-body branch from e0e4ffe to c1e8ede Compare April 25, 2021 16:08
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2021
@parthea parthea self-assigned this Apr 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2021
@parthea parthea requested review from busunkim96 and tswast April 26, 2021 17:43
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@parthea
Copy link
Contributor Author

parthea commented Apr 30, 2021

@busunkim96 @tswast PTAL

Copy link

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for better test coverage!

I see from the tests that feat(bigquery) is coming from the summary column, but I don't see in this PR where that is happening. Was it always in the summary and we're just including that in the PR body now?

@parthea
Copy link
Contributor Author

parthea commented Apr 30, 2021

Hooray for better test coverage!

I see from the tests that feat(bigquery) is coming from the summary column, but I don't see in this PR where that is happening. Was it always in the summary and we're just including that in the PR body now?

Correct! It's already included in the summary. The reason that I included it previously was because I also used conventional commit messages in the individual commits for each API. For example, see this commit which has a commit message that begins with feat(admin): update the api.

@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021
@parthea
Copy link
Contributor Author

parthea commented May 10, 2021

@busunkim96 PTAL

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 11, 2021
@parthea parthea merged commit 6a88422 into master May 11, 2021
@parthea parthea deleted the add-conventional-commits-to-pr-body branch May 11, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include conventional commit messages in PR body when updating discovery artifacts

4 participants