Skip to content

chore: Add conventional commits to PR body of discovery document update #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 19 commits into from
May 11, 2021
Merged

chore: Add conventional commits to PR body of discovery document update #1314

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
be83e1f
chore: Add conventional commits to PR body for discovery updates
parthea Apr 25, 2021
c2309eb
add tests for buildprbody.py
parthea Apr 25, 2021
ac19c55
Increase coverage for scripts folder to 91%
parthea Apr 25, 2021
024ba57
Remove test code
parthea Apr 25, 2021
d177bf0
Fix typo
parthea Apr 25, 2021
8878c01
Run black on scripts folder
parthea Apr 25, 2021
dd612f7
Merge branch 'master' of github.com:googleapis/google-api-python-clie…
parthea Apr 25, 2021
c1e8ede
Remove commented code
parthea Apr 25, 2021
36c8ada
Fix typo
parthea Apr 25, 2021
bdb579b
Merge branch 'master' into add-conventional-commits-to-pr-body
parthea Apr 29, 2021
b1250e2
Update docstring in scripts/buildprbody.py
parthea Apr 30, 2021
cf541b1
Use slash instead of pathlib.Path.joinpath()
parthea May 2, 2021
44c1af1
Include the child key in the summary if it is not grouped with other …
parthea May 7, 2021
80b56f1
Reduce the size of the test data
parthea May 7, 2021
bd88901
Merge branch 'master' into add-conventional-commits-to-pr-body
parthea May 7, 2021
c42af39
Fix build
parthea May 7, 2021
59bc42b
Merge branch 'master' into add-conventional-commits-to-pr-body
parthea May 8, 2021
0c1b07d
Merge branch 'master' into add-conventional-commits-to-pr-body
parthea May 9, 2021
79d0dec
Merge branch 'master' into add-conventional-commits-to-pr-body
parthea May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use slash instead of pathlib.Path.joinpath()
  • Loading branch information
@parthea
parthea committed May 2, 2021
commit cf541b182f43cbdc69e7dc751ae0f3a907fb0950
4 changes: 1 addition & 3 deletions scripts/buildprbody.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ def get_commit_uri(self, name):
sha = None
api_link = ""

file_path = pathlib.Path(self._change_summary_directory).joinpath(
"{0}.sha".format(name)
)
file_path = pathlib.Path(self._change_summary_directory) / "{0}.sha".format(name)
if file_path.is_file():
with open(file_path, "r") as f:
sha = f.readline().rstrip()
Expand Down