Skip to content

Conversation

@sakthivelmanii
Copy link
Contributor

@sakthivelmanii sakthivelmanii commented Oct 23, 2025

Default keep alive time is 120 seconds. If customer wants to override they can override it by passing the keepAlive configuration in the opts.

@sakthivelmanii sakthivelmanii requested review from a team as code owners October 23, 2025 13:07
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sakthivelmanii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix to configure the keepalive time for gRPC TCP connections within the Spanner client. The primary goal is to improve the robustness and reliability of gRPC communication by ensuring that connections remain active and are not prematurely terminated due to inactivity, which can often occur with network intermediaries. This change specifically sets a client-side keepalive interval to 120 seconds.

Highlights

  • gRPC Keepalive Configuration: This pull request introduces a client-side keepalive configuration for gRPC TCP connections, setting a Time parameter of 120 seconds.
  • Improved Connection Reliability: By configuring keepalives, the change aims to prevent idle gRPC connections from being silently dropped by network proxies or firewalls, thereby enhancing connection stability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a gRPC keepalive parameter to TCP connections to prevent them from being dropped due to inactivity. While this is a good improvement, the keepalive duration is hardcoded. My feedback suggests making this value configurable to provide more flexibility for users of this client, who may be operating in different network environments with varying idle timeout policies.

@quartzmo quartzmo changed the title fix: Configure keepAlive time for gRPC TCP connections fix(spanner): Configure keepAlive time for gRPC TCP connections Oct 23, 2025
@sakthivelmanii sakthivelmanii force-pushed the set_default_keepalive_time branch from d4d6600 to 50ec00b Compare October 23, 2025 16:43
@sakthivelmanii sakthivelmanii merged commit ca8f64e into main Oct 24, 2025
10 checks passed
@sakthivelmanii sakthivelmanii deleted the set_default_keepalive_time branch October 24, 2025 09:45
rahul2393 added a commit that referenced this pull request Dec 15, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d
<details><summary>spanner: 1.87.0</summary>

##
[1.87.0](spanner/v1.86.1...spanner/v1.87.0)
(2025-12-10)

### Features

* Add Send and Ack mutations for Queues (PiperOrigin-RevId: 832425466)
([185951b](185951b3))

* Exposing AutoscalingConfig in InstancePartition (PiperOrigin-RevId:
825184314)
([185951b](185951b3))

* Add Spanner location API (PiperOrigin-RevId: 833474957)
([185951b](185951b3))

* Add QueryAdvisorResult for query plan (PiperOrigin-RevId: 832425466)
([185951b](185951b3))

* improve the SQL formatting when printing out SQL (#13267)
([af0806f](af0806f4))

* Add grpc.xds.resource_type label to xDS client metrics (#13358)
([b9196cf](b9196cf6))

* support subquery in View Join (#13266)
([d19f797](d19f797b))

### Bug Fixes

* add env var to allow disabling directpath bound token (#13265)
([029bc79](029bc795))

* fix createMultiplexedSession goroutine leak (#13396)
([1805e89](1805e895))

* decoding spanner rows using SelectAll should map values in correct
annotations (#13301)
([315f65b](315f65b5))

* error instead of panic for iterator after tx end (#13366)
([a27c19a](a27c19ae))

* transaction_tag should be set on BeginTransactionRequest (#13463)
([a429aea](a429aea4))

* Configure keepAlive time for gRPC TCP connections (#13216)
([ca8f64e](ca8f64e0))

* avoid double decrement in session counting (#13395)
([e036421](e0364214))

### Documentation

* minor update for Spanner Location API (PiperOrigin-RevId: 834841888)
([185951b](185951b3))

* Update description for the BatchCreateSessionsRequest and Session
(PiperOrigin-RevId: 832425466)
([185951b](185951b3))

* Update description for the IsolationLevel (PiperOrigin-RevId:
832425466)
([185951b](185951b3))

</details>
cpriti-os pushed a commit to cpriti-os/google-cloud-go that referenced this pull request Dec 16, 2025
…3464)

PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d
<details><summary>spanner: 1.87.0</summary>

##
[1.87.0](googleapis/google-cloud-go@spanner/v1.86.1...spanner/v1.87.0)
(2025-12-10)

### Features

* Add Send and Ack mutations for Queues (PiperOrigin-RevId: 832425466)
([185951b](googleapis@185951b3))

* Exposing AutoscalingConfig in InstancePartition (PiperOrigin-RevId:
825184314)
([185951b](googleapis@185951b3))

* Add Spanner location API (PiperOrigin-RevId: 833474957)
([185951b](googleapis@185951b3))

* Add QueryAdvisorResult for query plan (PiperOrigin-RevId: 832425466)
([185951b](googleapis@185951b3))

* improve the SQL formatting when printing out SQL (googleapis#13267)
([af0806f](googleapis@af0806f4))

* Add grpc.xds.resource_type label to xDS client metrics (googleapis#13358)
([b9196cf](googleapis@b9196cf6))

* support subquery in View Join (googleapis#13266)
([d19f797](googleapis@d19f797b))

### Bug Fixes

* add env var to allow disabling directpath bound token (googleapis#13265)
([029bc79](googleapis@029bc795))

* fix createMultiplexedSession goroutine leak (googleapis#13396)
([1805e89](googleapis@1805e895))

* decoding spanner rows using SelectAll should map values in correct
annotations (googleapis#13301)
([315f65b](googleapis@315f65b5))

* error instead of panic for iterator after tx end (googleapis#13366)
([a27c19a](googleapis@a27c19ae))

* transaction_tag should be set on BeginTransactionRequest (googleapis#13463)
([a429aea](googleapis@a429aea4))

* Configure keepAlive time for gRPC TCP connections (googleapis#13216)
([ca8f64e](googleapis@ca8f64e0))

* avoid double decrement in session counting (googleapis#13395)
([e036421](googleapis@e0364214))

### Documentation

* minor update for Spanner Location API (PiperOrigin-RevId: 834841888)
([185951b](googleapis@185951b3))

* Update description for the BatchCreateSessionsRequest and Session
(PiperOrigin-RevId: 832425466)
([185951b](googleapis@185951b3))

* Update description for the IsolationLevel (PiperOrigin-RevId:
832425466)
([185951b](googleapis@185951b3))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants