Make json serialization treat maps as maps, always.

[mikekap]

Even if they are iterable, like clojure maps. See googleapis/google-cloud-java#1890 . See https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/APersistentMap.java#L16 .

[jeanbza]

Hello - thanks for contributing. Just a quick update that this repository is currently frozen whilst we fix some backend stuff related to the release process, and submit a release. It should be unfrozen in a few weeks.

More generally, this repository is in maintenance mode; we may not be able to get to this PR for some time.

[chingor13]

Thanks for contributing this!

Is there a sample test case we can add to demonstrate this fix?

[mikekap]

@chingor13 I'm not 100% sure where to put the tests - it doesn't look like there are any generator tests currently - only parser tests. From my perspective, I'm using https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/com/google/cloud/bigquery/InsertAllRequest.Builder.html#addRow-java.lang.String-java.util.Map- - which takes an arbitrary map. This currently fails spectacularly for Clojure maps, but generally an implementation of Map that looks like this will fail:

import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
import java.util.Spliterator;
import java.util.function.Consumer;

public class IterableMap extends HashMap<String, String> implements Iterable<Map.Entry<String, String>> {
    @Override
    public Iterator<Entry<String, String>> iterator() {
        return entrySet().iterator();
    }

    @Override
    public void forEach(Consumer<? super Entry<String, String>> action) {
        entrySet().forEach(action);
    }

    @Override
    public Spliterator<Entry<String, String>> spliterator() {
        return entrySet().spliterator();
    }
}

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[chingor13]

Bleh, GitHub did not like the merge from master.

[chingor13]

@mikekap Sorry, I messed up your branch trying to merge from master (to run CI). I created #550 with the added tests and cherry-picked your commit into there.