Skip to content

Add write timeout for post/put requests #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 9, 2018
Merged

Add write timeout for post/put requests #485

merged 11 commits into from
Nov 9, 2018

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Sep 27, 2018 •
edited
Loading

Fixes #484

  • Tests pass
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2018
@chingor13 chingor13 changed the title WIP: Add write timeout for post/put requests Add write timeout for post/put requests Oct 4, 2018
@chingor13 chingor13 requested a review from a team October 4, 2018 01:10
@chingor13
Copy link
Contributor Author

chingor13 commented Oct 4, 2018

We should merge this and build a snapshot for customers to try before we release it.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2018
@chingor13
Copy link
Contributor Author

chingor13 commented Oct 8, 2018

Note that this failed internal testing, so trying to resolve those failures.

@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2018
@chingor13
Copy link
Contributor Author

chingor13 commented Nov 8, 2018

This is still not passing internal testing

@chingor13
Copy link
Contributor Author

chingor13 commented Nov 9, 2018

Internal tests pass with internal whitelisting of blocking IO calls.

@chingor13 chingor13 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2018
@chingor13 chingor13 merged commit 7b95ce8 into googleapis:master Nov 9, 2018
@chingor13 chingor13 deleted the write-timeout branch November 9, 2018 17:24
@chingor13 chingor13 mentioned this pull request Nov 9, 2018
Merged
@medb medb mentioned this pull request Jan 25, 2022
Closed
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@renovate-bot
chore(deps): update dependency junit:junit to v4.13.1 (googleapis#485)
72a00b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

2 more reviewers

@huygaa11 huygaa11 huygaa11 left review comments

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chingor13 @huygaa11 @JesseLovelace @googlebot @kokoro-team