Skip to content

Add write timeout for post/put requests #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 9, 2018
Merged

Add write timeout for post/put requests #485

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4eb2391
Introduce API to set writeTimeout and use it in the NetHttp request
chingor13 Sep 26, 2018
6f2122a
Surface the writeTimeout to HttpRequest
chingor13 Sep 26, 2018
8b29f5d
remove debug statements
chingor13 Oct 4, 2018
689e66f
Merge branch 'master' into write-timeout
chingor13 Oct 4, 2018
89e3e68
Fix warnings
chingor13 Oct 4, 2018
e3bd6f1
Fix syntax
chingor13 Oct 4, 2018
8d91756
DI for testing
chingor13 Oct 4, 2018
1297949
Merge remote-tracking branch 'upstream/master' into write-timeout
chingor13 Nov 6, 2018
ed27703
Merge branch 'master' into write-timeout
chingor13 Nov 6, 2018
93ab5f9
Make field constant field final
chingor13 Nov 6, 2018
703eca9
Merge branch 'master' into write-timeout
chingor13 Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix warnings
  • Loading branch information
@chingor13
chingor13 committed Oct 4, 2018
commit 89e3e68391ee608f3a0b1d729fe660d55b9c54e0
4 changes: 2 additions & 2 deletions google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ private void writeContentToOutputStream(OutputStream out)
// Use and executor service and futures to handle this
final OutputStream outputStream = out;
final StreamingContent content = getStreamingContent();
final Callable<Boolean> writeContent = new Callable() {
final Callable<Boolean> writeContent = new Callable<Boolean>() {
@Override
public Boolean call() throws IOException {
content.writeTo(outputStream);
return Boolean.TRUE;
}
};
final ExecutorService executor = Executors.newSingleThreadExecutor();
final Future future = executor.submit(new FutureTask<Boolean>(writeContent));
final Future<Boolean> future = executor.submit(new FutureTask<Boolean>(writeContent));
executor.shutdown();

try {
Expand Down