Remove commons-codec dependency #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kolea2
reviewed
Jan 4, 2019
google-http-client/src/main/java/com/google/api/client/util/StringUtils.java
Show resolved
Hide resolved
chingor13
force-pushed
the
replace-commons-codec
branch
from
ff9d60e to
58e4368
Compare
kolea2
approved these changes
Jan 4, 2019
This was referenced Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
Use guava Base64 handling until we drop Java 7 support and can use the built-in classes.
Use Java 7 charset handling for StringUtils.
By removing commons-codec, we should no longer need to jarjar a shaded version of commons-codec (and guava). We can also remove the antrun plugin which scrubbed the shaded commons-codec. This will also unblock the windows tests in #562 (file permissions errors during antrun plugin) Edit: it unblocked it, but there are more failures.