Skip to content

Remove commons-codec dependency #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Remove commons-codec dependency #563

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8496a72
Replace string utf8 helpers
chingor13 Jan 4, 2019
c56daf5
Use guava for base64 encoding/decoding
chingor13 Jan 4, 2019
fdce90d
Remove commons-codec dependencies
chingor13 Jan 4, 2019
b960eca
Fix urlsafe string encoding
chingor13 Jan 4, 2019
58e4368
Add tests for null edge cases for StringUtils
chingor13 Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add tests for null edge cases for StringUtils
  • Loading branch information
@chingor13
chingor13 committed Jan 4, 2019
commit 58e4368306a76002269e0962a80a098f1aeb6d4c
8 changes: 8 additions & 0 deletions google-http-client/src/test/java/com/google/api/client/util/StringUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,15 @@ public void testToBytesUtf8() {
Assert.assertArrayEquals(SAMPLE_UTF8, StringUtils.getBytesUtf8(SAMPLE));
}

public void testToBytesUtf8Null() {
assertNull(StringUtils.getBytesUtf8(null));
}

public void testFromBytesUtf8() {
assertEquals(SAMPLE, StringUtils.newStringUtf8(SAMPLE_UTF8));
}

public void testFromBytesUtf8Null() {
assertNull(StringUtils.newStringUtf8(null));
}
}