Republish the fixed apache extensions as google-http-client-apache-v2 #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Deprecates the package com.google.api.client.http.apache Deprecates the com.google.api.client.http.apache.AppacheHttpTransport class.
…n the apache artifact
elharo
reviewed
May 15, 2019
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I think the version needs to move to 130.0-SNAPSHOT before or during this PR. Right now there's a mix of 1.29.2 and 1.30.0 here.
| <version>2.1.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-apache:current} --> | ||
| <name>Apache HTTP transport for the Google HTTP Client Library for Java.</name> | ||
| <artifactId>google-http-client-apache-v2</artifactId> | ||
| <version>1.29.2-SNAPSHOT</version><!-- {x-version-update:google-http-client-apache-v2:current} --> |
Contributor
There was a problem hiding this comment.
should we jump to 1.30.0-SNAPSHOT?
Contributor
Author
There was a problem hiding this comment.
Our release tools will correctly version bump all of the artifacts. This should be included in the 1.30.0 release.
| ApacheHttpRequest(HttpClient httpClient, HttpRequestBase request) { | ||
| this.httpClient = httpClient; | ||
| this.request = request; | ||
| this.requestConfig = RequestConfig.custom().setRedirectsEnabled(false); |
Contributor
There was a problem hiding this comment.
This is the sort of detail—no redirects—it's useful to include in library documentation.
Contributor
Author
There was a problem hiding this comment.
This is more of an implementation detail. google-http-client configures redirects so we turn off the underlying automatic redirects in the Apache client.
...client-apache-v2/src/main/java/com/google/api/client/http/apache/v2/ApacheHttpTransport.java
Outdated
Show resolved
Hide resolved
...client-apache-v2/src/main/java/com/google/api/client/http/apache/v2/ApacheHttpTransport.java
Outdated
Show resolved
Hide resolved
...client-apache-v2/src/main/java/com/google/api/client/http/apache/v2/ApacheHttpTransport.java
Outdated
Show resolved
Hide resolved
...nt-apache-v2/src/test/java/com/google/api/client/http/apache/v2/ApacheHttpTransportTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| ApacheHttpTransport transport = new ApacheHttpTransport(mockClient); | ||
|
|
||
| // Test GET. |
Contributor
There was a problem hiding this comment.
These should probably be seven separate methods with a common setup here.
...nt-apache-v2/src/test/java/com/google/api/client/http/apache/v2/ApacheHttpTransportTest.java
Outdated
Show resolved
Hide resolved
...nt-apache-v2/src/test/java/com/google/api/client/http/apache/v2/ApacheHttpTransportTest.java
Outdated
Show resolved
Hide resolved
...nt-apache-v2/src/test/java/com/google/api/client/http/apache/v2/ApacheHttpTransportTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
May 15, 2019
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.29.0 reverted the changes that split the
google-http-client-apacheartifact out ofgoogle-http-client. Rather than "breaking" the original artifact, we will provide a new artifactgoogle-http-client-apache-v2which provides a new packagecom.google.api.client.http.apache.v2.This also removes the
google-http-client-apacheandgoogle-http-client-apache-legacymodules. The legacy code still exists in the basegoogle-http-clientartifact and is now deprecated.The new artifact will be versioned the same as the rest of the packages (so will start at 1.30.0 when first released).