23andMe API & google oauth2 - round trip working example w/ sickle cell anemia #140
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
dennisbyrne
force-pushed
the
sample-23andMe-application
branch
from
9028f90 to
4b81172
Compare
dennisbyrne
force-pushed
the
sample-23andMe-application
branch
from
4b81172 to
2d4ecef
Compare
|
CLAs look good, thanks! |
|
I signed it! |
|
It would be nice to get a link to this contribution on this page as well https://developers.google.com/api-client-library/java/google-oauth-java-client/samples . Any help on how to get that done would be much appreciated ... thanks in advance. |
|
Can someone please review this PR? |
|
Hello, this PR hasn't received an initial review in six months. Can someone please review this? |
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
Thanks - I'm not sure this is the right place to host this. Probably a better place would be to submit it to: https://github.com/GoogleCloudPlatform/community and ask me for a review there. Take a look at the contributing guidelines.
| @@ -0,0 +1 @@ | |||
| mvn compile && mvn -q exec:java -Dexec.args="client_id client_secret" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,78 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| <artifactId>google-oauth-client</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.oauth-client</groupId> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| AUTHORIZATION_SERVER_URL) | ||
| .setScopes(SCOPES) | ||
| .setDataStoreFactory(dataStoreFactory).build(); | ||
| VerificationCodeReceiver receiver = new LocalServerReceiver.Builder().setHost(DOMAIN) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Hello @lesv ... I will address each of your code comments but I was curious as to why you prefer https://github.com/GoogleCloudPlatform/community ? My reasoning for targeting the PR to this repo began with https://developers.google.com/api-client-library/java/google-oauth-java-client/samples , so I made a peer to https://github.com/google/google-oauth-java-client/tree/master/samples/dailymotion-cmdline-sample (which is currently the only sample). Thank you for looking at my PR, I will address your other comments shortly. |
|
I was thinking folks would be more likely to find it on https://cloud.google.com/community/ . If you'd prefer it here, I'll merge it. (once the changes are done). |
|
https://cloud.google.com/community/ it is then :) I'll need 24 hrs to get to this, thanks. |
4 participants
This PR adds a new sample app to your code base. The sample app uses Google's OAuth 2.0 java lib to authenticate into 23andMe, and pull a single genotype for i3003137, a SNP associated with Sickle Cell Anemia.