23andMe API & google oauth2 - round trip working example w/ sickle cell anemia #140
Conversation
| * you will be given a client_id and a client_secret | ||
| * Clone the community repo and run the sample app | ||
| * make sure you have [maven installed][install_maven] | ||
| * $ git clone https://github.com/GoogleCloudPlatform/community.git |
There was a problem hiding this comment.
You can use command syntax on these lines by indenting them with 6 spaces (and leaving an empty line after the bullet-list item. also please remove the $ indicators, they make copy/paste more difficult.
| @@ -0,0 +1,17 @@ | |||
| This sample app uses Google's OAuth 2.0 java lib to authenticate with 23andMe. Once authenticated the app pulls a single genotype for i3003137, a SNP associated with Sickle Cell Anemia. | |||
There was a problem hiding this comment.
The tutorial needs header section. Take a look at the other tutorials.
| This sample app uses Google's OAuth 2.0 java lib to authenticate with 23andMe. Once authenticated the app pulls a single genotype for i3003137, a SNP associated with Sickle Cell Anemia. | ||
|
|
||
| ### Instructions | ||
| * Create a 23andMe client at https://api.23andme.com/apply/ |
There was a problem hiding this comment.
Might be write this down as normal text instead of bullet-list items. It just makes markdown harder to write and users follow the tutorials linearly anyway. You can have it like:
### Step 1: do this
Explain
command
### Step 2: do this
Explain
command
| ### Instructions | ||
| * Create a 23andMe client at https://api.23andme.com/apply/ | ||
| * set your redirect_uri of http://127.0.0.1:8080/Callback | ||
| * you will be given a client_id and a client_secret |
There was a problem hiding this comment.
consider using backticks sytax to render them as client_id and client_secret
| @@ -1,3 +1,11 @@ | |||
| --- | |||
| title: 23andMe API & google oauth2 in java | |||
| description: round trip working example w/ sickle cell anemia | |||
There was a problem hiding this comment.
Capitalize the description and provide a better text (e.g. w/ is not appropriate). These show up in https://cloud.google.com/community/tutorials/, you can take a look at other tutorials for examples.
| @@ -1,3 +1,11 @@ | |||
| --- | |||
| title: 23andMe API & google oauth2 in java | |||
There was a problem hiding this comment.
Some words here need to be capitalized as this is an actual page title. I suggest roughly something like:
Authenticating to 23andMe API with Google OAuth client
|
@jmdobry @lesv It looks like the Java OAuth Client is not directly related to the Cloud but a broader set of Google APIs. Would this tutorial be a good fit for GoogleCloud community page? Is there a community samples area for developers.google.com projects? The https://developers.google.com/api-client-library/java/google-oauth-java-client/samples page for this project features DailyMotion. This request is fairly similar (a third party API sample). I'm not sure if this content should be here. |
|
@ahmetb the original PR was a peer of https://developers.google.com/api-client-library/java/google-oauth-java-client/samples ... see googleapis/google-oauth-java-client#140 . |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@dennisbyrne I think so, it has better SEO than anywhere else you might place it, and we are the ones who maintain that repo. |
|
@ahmetb Ah - I think it's better here than anywhere else. |
|
Wow ... what are the chances that they would get the same PR ID? |
|
Dennis, any idea why the CLA bot is complaining about your signing of the CLA? |
|
@JimTravis I have no idea. It may have something to do w/ the fact that these commits were done with [email protected] (I am at work right now) but my primary email address for my github account is [email protected] . I will sign a second CLA as [email protected]. |
|
Looks like I can only sign CLAs as google email addresses. Makes sense. I still don't know why the check failed. |
|
CLAs look good, thanks! |
|
@JimTravis I figured out why the CLA check failed. The original commit was from [email protected], my primary email for my github account. All subsequent commits were by [email protected]. I have squashed my commits. The check should pass. |
|
Thanks @JimTravis ... about how long until this shows up at https://cloud.google.com/community/tutorials/ no rush |
|
It's been published. |
|
Great, I'll link to it from https://api.23andme.com/docs . Thanks everyone. |
|
Thank you!
…On Thu, Apr 27, 2017 at 4:25 PM, Dennis Byrne ***@***.***> wrote:
Great, I'll link to it from https://api.23andme.product/docs . Thanks
everyone.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKKwPsXMEkP1o9GYLvmYJVL_Os4WiNymks5r0SPwgaJpZM4NJfAu>
.
|
6 participants
Tagging @lesv regarding googleapis/google-oauth-java-client#140 . I have ported my sample app to this repo and addressed your comments.