Add package definition loader function to native package #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
reviewed
Feb 27, 2018
packages/grpc-native-core/index.js
Outdated
| for (const serviceFqn in packageDef) { | ||
| const service = packageDef[serviceFqn]; | ||
| const nameComponents = serviceFqn.split('.'); | ||
| const serviceName = nameComponents[-1]; |
Contributor
There was a problem hiding this comment.
Did you mean nameComponents.slice(-1)[0]?
Member
Author
There was a problem hiding this comment.
Yes, something like that. I forgot that wasn't a thing in JavaScript.
kjin
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kjin This is the implementation in the existing native library of the function to load the "package definition" from the protobuf library. As you can see, it calls
makeClientConstructor, which is the other function that is not currently implemented in the pure JavaScript implementation.The result type for this looks something like