Skip to content

Add package definition loader function to native package #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murgatroid99 merged 2 commits into from
Feb 27, 2018
Merged

Add package definition loader function to native package #196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda109e
Add package definition loader function to native package
murgatroid99 Feb 22, 2018
ea704f9
Fix a couple of issues with the package loader function
murgatroid99 Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix a couple of issues with the package loader function
  • Loading branch information
@murgatroid99
murgatroid99 committed Feb 27, 2018
commit ea704f94391c76562aa5a74565ce917c26ab6720
10 changes: 5 additions & 5 deletions packages/grpc-native-core/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,13 @@ exports.loadPackageDefinition = function loadPackageDefintion(packageDef) {
for (const serviceFqn in packageDef) {
const service = packageDef[serviceFqn];
const nameComponents = serviceFqn.split('.');
const serviceName = nameComponents[-1];
const serviceName = nameComponents[nameComponents.length-1];
let current = result;
for (const package in nameComponents.slice(0, -1)) {
if (!current[package]) {
current[package] = {};
for (const packageName in nameComponents.slice(0, -1)) {
if (!current[packageName]) {
current[packageName] = {};
}
current = current[package];
current = current[packageName];
}
current[serviceName] = client.makeClientConstructor(service, serviceName, {});
}
Expand Down