Skip to content

Fix memory_space type_alias in DerivFieldMem. Fixes gyselax#558#559

Merged
EmilyBourne merged 3 commits into
gyselax:develfrom
Quntized:fix-derivfieldmem-memspace
Feb 25, 2026
Merged

Fix memory_space type_alias in DerivFieldMem. Fixes gyselax#558#559
EmilyBourne merged 3 commits into
gyselax:develfrom
Quntized:fix-derivfieldmem-memspace

Conversation

@Quntized

@Quntized Quntized commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Fix Incorrect memory_space type_alias in DerivFieldMem. It was set to typename base_type::element_type (bug) instead of MemSpace .

This is the same bug as #552 , but in DerivFieldMem instead of DerivField

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

  • Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
  • Have you updated the CHANGELOG.md ?
  • Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
  • Have you checked that the AUTHORS file is up to date ?
  • Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
  • Do you follow the conventions specified in our coding standards ?

New Feature Submissions

  • Have you added tests for the new functionalities ?
  • Have you documented the new functionalities:
    • API documentation describing the available methods, when each should be used and how to use them ?
    • User-friendly documentation in README files (which may link to the API documentation).
    • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

  • Have you checked that existing tests cover all code after the changes ?
  • Have you checked that existing tests are still passing ?
  • Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

  • Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

@EmilyBourne

Copy link
Copy Markdown
Member

We should have thought to check this file when we merged the last MR 😅

@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@EmilyBourne EmilyBourne merged commit eff0b0d into gyselax:devel Feb 25, 2026
25 of 27 checks passed
EmilyBourne pushed a commit that referenced this pull request Mar 5, 2026
Fix Incorrect `memory_space ` type_alias in `DerivFieldMem`. It was set
to `typename base_type::element_type ` (bug) instead of `MemSpace` .

This is the same bug as #552 , but in `DerivFieldMem` instead of
`DerivField`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants