Skip to content

Fix memory_space type_alias in DerivFieldMem. Fixes gyselax#558 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilyBourne merged 3 commits into from
Feb 25, 2026
Merged

Fix memory_space type_alias in DerivFieldMem. Fixes gyselax#558 #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b4c5f
Fix memory_space type_alias in DerivFieldMem. Fixes gyselax#558
Quntized Feb 25, 2026
ed4b772
Merge branch 'devel' into fix-derivfieldmem-memspace
Quntized Feb 25, 2026
44c5b5d
Add changelog entry for DerivFieldMem memory_space fix
Quntized Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fix incorrect `memory_space` type alias in `DerivFieldMem`.
- Fix incorrect `memory_space` type alias in `DerivField`.
- Fix a memory leak in `DerivFieldMem`.
- Fix `ddc::coordinate` called on `ddc::DiscreteElement` outside of the domain of definition in `single_interface_derivatives_calculator.hpp` and tests.
Expand Down
2 changes: 1 addition & 1 deletion src/data_types/derivative_field_mem.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class DerivFieldMem<ElementType, IdxRange<DDims...>, NDerivs, MemSpace>
using element_type = typename base_type::element_type;

/// @brief The type of the memory space where the field is saved (CPU vs GPU).
using memory_space = typename base_type::element_type;
using memory_space = MemSpace;

/**
* @brief The IdxRange on which the chunks in this object are defined.
Expand Down
Loading