Fix: correct column index assertion in Matrix_Corner_Block and Matrix_Periodic_Banded #566

[Quntized]

Fix: correct column index assertion in Matrix_Corner_Block and Matrix_Periodic_Banded #566

In src/matrix_tools/matrix_corner_block.cpp and src/matrix_tools/matrix_periodic_banded.cpp both get_element and set_element contain same assert twice assert(i < n); and not the check for j any. This maybe copy-paste typo accidentally.

double Matrix_Corner_Block::get_element(int const i, int const j) const
{
    assert(i >= 0);
    assert(i < n);
    assert(j >= 0);
    assert(i < n);   //This should be checked for j;
   ....
}

and

void Matrix_Corner_Block::set_element(int const i, int const j, double const a_ij)
{
   assert(i >= 0);
   assert(i < n);
   assert(j >= 0);
   assert(i < n);    //Same for this one;
  .....
}

double Matrix_Periodic_Banded::get_element(int const i, int j) const
{
    assert(i >= 0);
    assert(i < n);
    assert(j >= 0);
    assert(i < n);   //Same for this one;
   .....
}

void Matrix_Periodic_Banded::set_element(int const i, int j, double const a_ij)
{
    assert(i >= 0);
    assert(i < n);
    assert(j >= 0);
    assert(i < n); //Same for this one;
   .......
}

---

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

• Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
• Have you updated the CHANGELOG.md ?
• Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
• Have you checked that the AUTHORS file is up to date ?
• Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
• Do you follow the conventions specified in our coding standards ?

New Feature Submissions

• Have you added tests for the new functionalities ?
• Have you documented the new functionalities:
  • API documentation describing the available methods, when each should be used and how to use them ?
  • User-friendly documentation in README files (which may link to the API documentation).
  • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

• Have you checked that existing tests cover all code after the changes ?
• Have you checked that existing tests are still passing ?
• Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

• Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

[EmilyBourne]

@Quntized Thanks again for this bug fix. Well done for catching all these corner cases!

[Quntized]

@Quntized Thanks again for this bug fix. Well done for catching all these corner cases!

Thank you, I'm really enjoying the project.
Happy to help — looking forward to contributing more!

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/matrix_tools/matrix_periodic_banded.cpp	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!