Skip to content

Fix: correct column index assertion in Matrix_Corner_Block and Matrix_Periodic_Banded #566 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilyBourne merged 2 commits into from
Mar 4, 2026
Merged

Fix: correct column index assertion in Matrix_Corner_Block and Matrix_Periodic_Banded #566 #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de40f4c
Fix: correct column index assertion in Matrix_Corner_Block and Matrix…
Quntized Mar 3, 2026
0ade4a6
Merge branch 'devel' into fix/matrix-corner-and-periodic-banded-asserion
Quntized Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/matrix_tools/matrix_corner_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ double Matrix_Corner_Block::get_element(int const i, int const j) const
assert(i >= 0);
assert(i < n);
assert(j >= 0);
assert(i < n);
assert(j < n);
if (i < nb && j < nb) {
return q_block->get_element(i, j);
} else if (i >= nb && j >= nb) {
Expand All @@ -71,7 +71,7 @@ void Matrix_Corner_Block::set_element(int const i, int const j, double const a_i
assert(i >= 0);
assert(i < n);
assert(j >= 0);
assert(i < n);
assert(j < n);
if (i < nb && j < nb) {
q_block->set_element(i, j, a_ij);
} else if (i >= nb && j >= nb) {
Expand Down
4 changes: 2 additions & 2 deletions src/matrix_tools/matrix_periodic_banded.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ double Matrix_Periodic_Banded::get_element(int const i, int j) const
assert(i >= 0);
assert(i < n);
assert(j >= 0);
assert(i < n);
assert(j < n);
if (i >= nb && j < nb) {
int d = j - i;
if (d > n / 2)
Expand All @@ -51,7 +51,7 @@ void Matrix_Periodic_Banded::set_element(int const i, int j, double const a_ij)
assert(i >= 0);
assert(i < n);
assert(j >= 0);
assert(i < n);
assert(j < n);
if (i >= nb && j < nb) {
int d = j - i;
if (d > n / 2)
Expand Down
Loading