add asserts in IdentityInterpolationBuilder and deduplicate knot_grid in LagrangeEvaluator#611
add asserts in IdentityInterpolationBuilder and deduplicate knot_grid in LagrangeEvaluator#611Quntized wants to merge 8 commits into
Conversation
| = std::nullopt) const | ||
| { | ||
| assert(!derivs_xmin.has_value() || derivs_xmin->size() == 0); | ||
| assert(!derivs_xmax.has_value() || derivs_xmax->size() == 0); |
There was a problem hiding this comment.
Seeing it's unused that's why I added , is that necessary?
There was a problem hiding this comment.
It is unused by design but is provided to make this Builder interchangeable with other builders (in particular the SplineBuilder) the size of the derivatives should be collected from the class though so the size should be correct unless derivatives are reused from a previous calculation
There was a problem hiding this comment.
Thank you for the explanation. That makes sense — since the derivative domains come from the builder itself via batched_derivs_xmin_domain(), the size is guaranteed to be correct in normal usage. Removed.
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
… into add_slagrange
|
I think everything's fine. I am closing this. If I find anything major issue, I will reopen it. Thank you for your time. |
Added defensive asserts in IdentityInterpolationBuilder::operator():
Check that derivative arguments are not silently ignored
Validate size match between coeffs and vals before deep_copy
Added missing #include
Deduplicated knot_grid type alias in LagrangeEvaluator:
Moved to class-level private type alias
Removed identical definitions from eval_no_bc and getclosest
Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.
All Submissions
New Feature Submissions
Changes to Existing Features
Changes to the CI