Skip to content

add asserts in IdentityInterpolationBuilder and deduplicate knot_grid in LagrangeEvaluator #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Quntized wants to merge 8 commits into from
Closed

add asserts in IdentityInterpolationBuilder and deduplicate knot_grid in LagrangeEvaluator #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91a169c
Added small stuff
Quntized Mar 29, 2026
ba852c9
Added small stuff
Quntized Mar 29, 2026
96aa9a8
Update src/interpolation/identity_interpolation_builder.hpp
Quntized Mar 30, 2026
9a79d8e
Merge branch 'devel' into add_slagrange
Quntized Mar 30, 2026
89744e9
Merge remote-tracking branch 'upstream' into add_slagrange
Quntized Mar 30, 2026
c7f85d9
removed deriv assertion
Quntized Mar 30, 2026
cf0e0d8
Merge branch 'add_slagrange' of https://github.com/Quntized/gyselalib…
Quntized Mar 30, 2026
88e87d8
Merge branch 'devel' into add_slagrange
Quntized Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/interpolation/identity_interpolation_builder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#pragma once

#include <cassert>

#include "ddc_aliases.hpp"
#include "i_interpolation_builder.hpp"

Expand Down Expand Up @@ -101,6 +103,7 @@ class IdentityInterpolationBuilder
IdxRange<basis_domain_type> bp_idx_range
= ddc::discrete_space<Basis>().break_point_domain().remove_last(
IdxStep<basis_domain_type>(static_cast<int>(Basis::is_periodic())));
assert(bp_idx_range.size() == vals.size());
Kokkos::deep_copy(
coeffs[bp_idx_range].allocation_kokkos_view(),
vals.allocation_kokkos_view());
Expand Down
12 changes: 4 additions & 8 deletions src/interpolation/lagrange_evaluator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ class LagrangeEvaluator
}

private:
using knot_grid = std::conditional_t<
LagrangeBasis::is_uniform(),
UniformLagrangeKnots<LagrangeBasis>,
sNonUniformLagrangeKnots<LagrangeBasis>>;
template <class Layout, class... CoordsDims>
KOKKOS_INLINE_FUNCTION DataType
eval(Coord<CoordsDims...> const& coord_eval,
Expand Down Expand Up @@ -530,10 +534,6 @@ class LagrangeEvaluator
const
{
using deriv_dim = ddc::Deriv<continuous_dimension_type>;
using knot_grid = std::conditional_t<
LagrangeBasis::is_uniform(),
UniformLagrangeKnots<LagrangeBasis>,
NonUniformLagrangeKnots<LagrangeBasis>>;
static_assert(
sizeof...(DerivDims) == 0
|| ddc::type_seq_same_v<
Expand Down Expand Up @@ -581,10 +581,6 @@ class LagrangeEvaluator
*/
KOKKOS_INLINE_FUNCTION auto getclosest(Coord<continuous_dimension_type> x_interp) const
{
using knot_grid = std::conditional_t<
LagrangeBasis::is_uniform(),
UniformLagrangeKnots<LagrangeBasis>,
NonUniformLagrangeKnots<LagrangeBasis>>;
Idx<knot_grid> first = ddc::discrete_space<LagrangeBasis>().break_point_domain().front();
if constexpr (ddc::is_uniform_point_sampling_v<knot_grid>) {
if constexpr (lagrange_basis_type::degree() % 2 == 0) {
Expand Down