VIBE-143 Add User Table In Database #116
Conversation
WalkthroughThis PR adds a Postgres-backed Prisma Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Browser
participant SSO_Callback as sso-callback
participant CFT_Callback as cft-callback
participant TokenClient as token-client
participant Repo as createOrUpdateUser
participant Prisma
participant Track as trackException
participant AppInsights as AppInsights
User->>Browser: Initiate login
Browser->>SSO_Callback: Redirect (SSO) / Browser->>CFT_Callback: Redirect (CFT)
alt SSO flow
SSO_Callback->>Repo: createOrUpdateUser({email, provenance: "SSO", provenanceId, role})
else CFT flow
CFT_Callback->>TokenClient: extract claims (uid, given_name, family_name, sub)
TokenClient-->>CFT_Callback: {id: uid, email, firstName, surname}
CFT_Callback->>Repo: createOrUpdateUser({email, firstName, surname, provenance: "CFT_IDAM", provenanceId: uid, role: "VERIFIED"})
end
Repo->>Prisma: findUnique by provenanceId
alt user exists
Prisma-->>Repo: user
Repo->>Prisma: update(role?, lastSignedInDate?)
Prisma-->>Repo: updated user
else user missing
Prisma-->>Repo: null
Repo->>Prisma: create(user fields, lastSignedInDate)
Prisma-->>Repo: created user
end
alt success
Repo-->>SSO_Callback: user
Repo-->>CFT_Callback: user
SSO_Callback->>Browser: continue login
CFT_Callback->>Browser: continue login
else error
Repo--xSSO_Callback: throw
SSO_Callback->>Track: trackException(error, { area: "auth", userEmail, userId })
Track->>AppInsights: trackException(...)
SSO_Callback->>Browser: redirect /login?error=db_error
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~40 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
libs/auth/src/user-repository/index.ts (1)
3-10: Consider adding runtime validation for provenance and role values.While TypeScript unions provide compile-time type safety, runtime validation would guard against invalid values from external sources (e.g., deserialized data, API calls). This could prevent invalid data from being persisted to the database.
Example validation:
const VALID_PROVENANCES = ["SSO", "CFT_IDAM", "CRIME_IDAM", "B2C_IDAM"] as const; const VALID_ROLES = ["VERIFIED", "LOCAL_ADMIN", "CTSC_ADMIN", "SYSTEM_ADMIN"] as const; function validateInput(input: CreateUserInput): void { if (!VALID_PROVENANCES.includes(input.userProvenance)) { throw new Error(`Invalid provenance: ${input.userProvenance}`); } if (!VALID_ROLES.includes(input.role)) { throw new Error(`Invalid role: ${input.role}`); } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
apps/postgres/prisma/schema.prisma(1 hunks)docs/tickets/VIBE-143/review.md(1 hunks)docs/tickets/VIBE-143/tasks.md(1 hunks)docs/tickets/VIBE-143/ticket.md(1 hunks)libs/auth/src/pages/cft-callback/index.ts(2 hunks)libs/auth/src/pages/sso-callback/index.ts(2 hunks)libs/auth/src/user-repository/index.test.ts(1 hunks)libs/auth/src/user-repository/index.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (3)
libs/auth/src/pages/cft-callback/index.ts (1)
libs/auth/src/user-repository/index.ts (1)
createOrUpdateUser(53-66)
libs/auth/src/pages/sso-callback/index.ts (1)
libs/auth/src/user-repository/index.ts (1)
createOrUpdateUser(53-66)
libs/auth/src/user-repository/index.test.ts (1)
libs/auth/src/user-repository/index.ts (6)
CreateUserInput(3-10)createUser(17-29)findUserByProvenanceId(31-35)findUserByEmail(37-41)updateUser(43-51)createOrUpdateUser(53-66)
🪛 LanguageTool
docs/tickets/VIBE-143/ticket.md
[style] ~38-~38: To form a complete sentence, be sure to include a subject.
Context: ...IMESTAMP | No | Date/Time (to seconds). Can be blank when user is first created | ...
(MISSING_IT_THERE)
docs/tickets/VIBE-143/review.md
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... role: ${role}`); } } ``` --- ##
(EN_COMPOUND_ADJECTIVE_INTERNAL)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: SonarQube Analysis
- GitHub Check: E2E Tests
🔇 Additional comments (2)
libs/auth/src/user-repository/index.test.ts (1)
1-320: Excellent test coverage!The test suite is comprehensive and well-structured, covering all repository methods with appropriate edge cases. The mocking strategy is correct, and the assertions validate both call parameters and return values.
libs/auth/src/user-repository/index.ts (1)
53-66: LGTM! Upsert pattern correctly implemented.The
createOrUpdateUserfunction correctly implements the upsert pattern as specified in the ticket requirements. It properly handles both new user creation and existing user updates, including role changes and timestamp updates.
🎭 Playwright E2E Test Results265 tests 265 ✅ 17m 42s ⏱️ Results for commit e25dcc2. ♻️ This comment has been updated with latest results. |
Replace console.error with trackException in SSO and CFT callback handlers to ensure failures during user creation/update are properly recorded in Application Insights. Add contextual properties (area, userEmail, userId) to aid debugging. Changes: - Create trackException helper function in cloud-native-platform - Update sso-callback to track exceptions with SSO context - Update cft-callback to track exceptions with CFT context - Export trackException from cloud-native-platform index 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
libs/auth/src/pages/cft-callback/index.ts (1)
1-7: Harden error handling and re‑considerdisplayNamesplitting
- Normalise caught errors for telemetry (as in SSO callback)
To avoid odd telemetry if a non‑Erroris thrown, consider the same pattern as suggested for the SSO callback:- // Create or update user record in database - try { + // Create or update user record in database + try { const nameParts = userInfo.displayName.split(" "); const firstName = nameParts[0] || undefined; const surname = nameParts.slice(1).join(" ") || undefined; await createOrUpdateUser({ email: userInfo.email, firstName, surname, userProvenance: "CFT_IDAM", userProvenanceId: userInfo.id, role: "VERIFIED" }); - } catch (error) { - trackException(error as Error, { + } catch (error) { + const err = error instanceof Error ? error : new Error(String(error)); + trackException(err, { area: "CFT callback", userEmail: userInfo.email, userId: userInfo.id }); // Continue with authentication even if database write fails }
- Name parsing remains simplistic
SplittingdisplayNameon spaces intofirstNameandsurnamewill mis-handle single names, multiple middle names, and many non‑Western formats. If the upstream CFT IDAM token exposes structured name fields, it would be more robust to prefer those and only fall back to this heuristic, or at least document the limitation where this parsing is defined.Also applies to: 45-66
🧹 Nitpick comments (1)
libs/auth/src/pages/sso-callback/index.ts (1)
2-6: Normalize caught errors before callingtrackExceptionThe persistence try/catch is in the right place and using
trackExceptionmeets the earlier monitoring requirement. To make this more robust against non-Errorthrows (e.g. strings), consider normalizing the caught value before passing it on:- // Create or update user record in database - try { + // Create or update user record in database + try { await createOrUpdateUser({ email: req.user.email, userProvenance: "SSO", userProvenanceId: req.user.id, role: req.user.role as "VERIFIED" | "LOCAL_ADMIN" | "CTSC_ADMIN" | "SYSTEM_ADMIN" }); - } catch (error) { - trackException(error as Error, { + } catch (error) { + const err = error instanceof Error ? error : new Error(String(error)); + trackException(err, { area: "SSO callback", userEmail: req.user?.email, userId: req.user?.id }); // Continue with authentication even if database write fails }This keeps the current behaviour while ensuring telemetry always receives a proper
Errorinstance.Also applies to: 36-51
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
libs/auth/src/pages/cft-callback/index.ts(2 hunks)libs/auth/src/pages/sso-callback/index.ts(2 hunks)libs/cloud-native-platform/src/index.ts(1 hunks)libs/cloud-native-platform/src/monitoring/track-exception.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
libs/auth/src/pages/cft-callback/index.ts (2)
libs/auth/src/user-repository/index.ts (1)
createOrUpdateUser(53-66)libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
trackException(11-22)
libs/auth/src/pages/sso-callback/index.ts (2)
libs/auth/src/user-repository/index.ts (1)
createOrUpdateUser(53-66)libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
trackException(11-22)
🔇 Additional comments (2)
libs/cloud-native-platform/src/index.ts (1)
7-7: ExposetrackExceptionat package root looks goodRe-exporting
./monitoring/track-exception.jskeeps the public surface consistent with other monitoring utilities and simplifies imports for callers.libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
1-22: Centralised exception tracking helper looks soundThe helper cleanly wraps exception tracking for routes that don’t have direct access to a monitoring service, with a defensive check around the default client and a console fallback. This should make it easy to add consistent telemetry from handlers like the SSO/CFT callbacks without risking runtime errors if monitoring isn’t initialised.
Please just confirm this logging pattern (both
console.errorand telemetry) aligns with your expected log volume and PII policy for thepropertiesyou pass in.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/auth/src/cft-idam/token-client.ts (1)
11-18: Guard against missing id/email/displayName claims when mapping token -> user.The new mapping to
uid/sub/given_name/family_nameis a good improvement over parsing a single display name. One concern: if the token ever omits some of these claims, we can end up with:
id: claims.uidbeingundefinedemail: claims.sub || claims.email || ""becoming an empty stringdisplayName: claims.name || claims.given_namebeingundefinedThose values then flow into
UserProfileand the user repository (e.g. asuserProvenanceIdandConsider adding explicit validation/fallbacks here (e.g. throw if
uidor email are missing, or fall back to a safer identifier), and/or add tests that cover missinguid/sub/namescenarios so failures are deterministic instead of silently producing invalid data.Also applies to: 77-84
🧹 Nitpick comments (3)
libs/auth/src/pages/cft-callback/index.test.ts (1)
53-60: Mocks correctly updated for new name fields; consider adding a focused upsert assertion.Including
firstNameandsurnamein the mockedextractUserInfoFromTokenresponses keeps these tests aligned with the expandedCftIdamUserInfoshape and the new persistence behaviour. If you want stronger coverage of the new DB upsert, consider (in this or a separate test) mocking../../user-repository/index.jsand asserting thatcreateOrUpdateUseris called with these fields when a non‑rejected user signs in.Also applies to: 90-97, 132-139, 158-165, 184-191, 212-219, 248-255
libs/auth/src/pages/cft-callback/index.ts (1)
1-1: CFT callback user upsert and exception tracking look solid.The new
createOrUpdateUsercall with CFT_IDAM provenance and thetrackException‑backed catch provide the right balance: DB issues are observable without blocking authentication. This cleanly wiresuid/email/firstName/surname into persistence while keeping the session flow unchanged.As a minor enhancement, you could add
provenanceandroleinto thetrackExceptionproperties for richer diagnostics, but the current implementation is already sufficient.Also applies to: 7-7, 45-62
libs/auth/src/cft-idam/token-client.test.ts (1)
80-86: Tests correctly cover uid/sub and new name fields; a couple of extra fallbacks would complete coverage.The updated tests now assert that:
uidis used foridandsubforgiven_name/family_namemap tofirstName/surname- Roles behaviour (array, empty, missing) is preserved
This matches the production mapping and gives good confidence. If you want to fully lock down the new logic, consider adding small tests for:
- Missing
namebut presentgiven_name(displayName fallback)- Missing
subbut presentNot strictly necessary, but would make the behaviour fully specified.
Also applies to: 99-106, 111-116, 129-136, 141-147, 163-168, 182-202
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
apps/postgres/prisma/migrations/20251121153203_create_user/migration.sql(1 hunks)apps/postgres/prisma/schema.prisma(1 hunks)libs/auth/src/cft-idam/token-client.test.ts(6 hunks)libs/auth/src/cft-idam/token-client.ts(2 hunks)libs/auth/src/pages/cft-callback/index.test.ts(7 hunks)libs/auth/src/pages/cft-callback/index.ts(2 hunks)libs/auth/src/user-repository/index.test.ts(1 hunks)libs/auth/src/user-repository/index.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- libs/auth/src/user-repository/index.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/postgres/prisma/schema.prisma
- libs/auth/src/user-repository/index.ts
🧰 Additional context used
🧬 Code graph analysis (1)
libs/auth/src/pages/cft-callback/index.ts (2)
libs/auth/src/user-repository/index.ts (1)
createOrUpdateUser(53-66)libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
trackException(11-22)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: SonarQube Analysis
- GitHub Check: E2E Tests
🔇 Additional comments (1)
apps/postgres/prisma/migrations/20251121153203_create_user/migration.sql (1)
1-17: Migration structure is sound.The table design properly supports the provenance-based upsert pattern with:
- UUID primary key for consistent, distributed user identification
- Unique constraint on
user_provenance_idto enforce single identity per auth provider- Appropriate nullable fields (
first_name,surname,last_signed_in_date)- Sensible column sizing and timestamp defaults
Assuming email is always populated, this migration aligns well with the repository layer expectations.
apps/postgres/prisma/migrations/20251121153203_create_user/migration.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/cloud-native-platform/src/monitoring/track-exception.test.ts (1)
108-118: Consider using a more maintainable mock restoration pattern.The manual mutation and restoration of
defaultClientworks but is fragile. If the mock structure evolves, the restoration logic in lines 115-117 requires manual updates. Consider extracting the mock creation into a helper function or usingvi.spyOnto temporarily override behavior.For example:
const createMockClient = () => ({ trackException: vi.fn() }); // In the outer beforeEach, you could reset properly // Or use vi.doMock with dynamic factoryThis would make the tests more maintainable and reduce the risk of test pollution.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/cloud-native-platform/src/monitoring/track-exception.test.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: E2E Tests
🔇 Additional comments (6)
libs/cloud-native-platform/src/monitoring/track-exception.test.ts (6)
1-3: LGTM!The imports are clean and appropriate for the test setup. The ESM-style import with
.jsextension is correct for TypeScript projects using ES modules.
5-13: LGTM!The mock setup correctly isolates the
applicationinsightsmodule for testing. The minimal mock structure with justtrackExceptionis appropriate for these focused unit tests.
18-25: LGTM!The test setup and teardown properly manages mock state and console spy lifecycle. Clearing mocks in
beforeEachand restoring the spy inafterEachensures test isolation.
27-105: LGTM!The test coverage for initialized Application Insights is thorough, checking basic exception tracking, properties handling, and edge cases like special characters and multiline messages. The assertions correctly verify both console logging and telemetry calls.
120-141: LGTM!The tests properly verify the fallback behavior when Application Insights is not initialized, ensuring errors and properties are still logged to the console with appropriate messaging.
144-212: LGTM!The edge case tests are well-designed, covering empty messages, nested objects, and null/undefined values. The use of
expect.any(String)for the timestamp field (line 182) is a good practice for testing dynamic values.
| @@ -0,0 +1,66 @@ | |||
| import { prisma } from "@hmcts/postgres"; | |||
There was a problem hiding this comment.
I thought in one of your previous tickets, you create a lib called account? Can it be moved there. In account create a folder called repository and add the repository method in a class called queries.ts. Please refer to publication/location and follow the same style
There was a problem hiding this comment.
agreed, move to account lib and rename it as well.
| @@ -0,0 +1,66 @@ | |||
| import { prisma } from "@hmcts/postgres"; | |||
|
|
|||
| export interface CreateUserInput { | |||
There was a problem hiding this comment.
Move this to account/repository/model.ts? Also rename the interface from CreateUserInput to just User.
| userEmail: req.user?.email, | ||
| userId: req.user?.id | ||
| }); | ||
| // Continue with authentication even if database write fails |
There was a problem hiding this comment.
Not sure if this behaviour is what we want. In current CaTH, we redirect to error page if the user failed to be created. Might need a chat to see what do we want for AI CaTH
There was a problem hiding this comment.
redirecting to error page now in case of any error.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/account/package.json (1)
5-13: Useworkspace:*or bounded semver for @hmcts/postgres peerDependency@hmcts/postgres is an internal workspace package (marked
"private": true), yet @hmcts/account references it as"*"in peerDependencies. This is inconsistent: all other packages in the monorepo reference @hmcts/postgres as a regular dependency with"workspace:*". Either switch to the workspace pattern or use a bounded semver range (e.g.,"^1.0.0") if peerDependency is intentional. Using"*"allows any external version and breaks the monorepo's internal dependency management.
🧹 Nitpick comments (6)
libs/auth/src/pages/sso-callback/index.test.ts (1)
13-16: Leverage the createOrUpdateUser mock in assertionsYou mock
createOrUpdateUserbut never assert on it; consider adding a happy‑path test that expects it to be called with the SSO user details, and another where it rejects to assert the/login?error=db_errorredirect and telemetry behaviour. This will protect the new persistence flow from regressions.libs/auth/src/pages/cft-callback/index.test.ts (1)
11-13: Add coverage for persistence interaction and db_error handlingYou’ve updated the token payloads to include
firstName/surnameand mocked@hmcts/account/repository/query, but the tests still only assert redirects and session behaviour. Consider in the successful authentication test:
- Asserting that
createOrUpdateUseris called withfirstName,surname, provenanceCFT_IDAM, and the correctuserProvenanceId/role.- Adding a test where
createOrUpdateUserrejects so you can assert the/sign-in?error=db_error&lng=...redirect and that telemetry is invoked.This will better exercise the new user‑persistence logic added to the CFT callback.
Also applies to: 56-63, 93-100, 135-142, 161-168, 187-194, 215-222, 251-258
libs/auth/src/pages/sso-callback/index.ts (1)
2-3: Persistence + telemetry wiring looks good; add tests and consider centralising role typeThe SSO callback now upserts the user via
createOrUpdateUserand usestrackExceptionwith useful context before redirecting to/login?error=db_error, which is a solid pattern. Two follow‑ups to consider:
- Add a unit test where
createOrUpdateUserrejects so you can assert both thetrackExceptioninvocation and the?error=db_errorredirect.- Avoid repeating the role string‑literal union here by reusing a shared role type (e.g. from the account model or a central enum) instead of
as "VERIFIED" | "LOCAL_ADMIN" | "CTSC_ADMIN" | "SYSTEM_ADMIN", to keep things in sync if roles change.Also double‑check with product/UX that failing back to
/login?error=db_errormatches the intended behaviour compared to the legacy CaTH flow.Also applies to: 36-51
libs/auth/src/pages/cft-callback/index.ts (1)
1-2: CFT persistence + telemetry integration is solid; add db_error test coverageThe CFT callback now upserts the user (including
firstName/surname) and usestrackExceptionwith contextual properties before redirecting to/sign-in?error=db_error&lng=${lng}on failure, which aligns well with the new repository and monitoring utilities.To tighten this up:
- Add a test where
createOrUpdateUserrejects, asserting thedb_errorredirect and that telemetry is called with the expectedarea,userEmail, anduserId.- (Optional) You can reuse the top‑level
lngconstant in the outercatchinstead of recomputing it.Also applies to: 45-62
libs/account/src/repository/model.ts (1)
1-13: Interfaces match repository usage; consider centralising shared enums
UserandUpdateUserInputcleanly capture the fields used by the repository and callbacks, with sensible unions foruserProvenanceandrole. To avoid drift as more parts of the system depend on these values, consider centralising the role/provenance unions (e.g. shared enum or exported type) and reusing them in auth flows and elsewhere rather than duplicating string literals.libs/account/src/repository/query.ts (1)
1-53: Consider Prisma upsert to consolidate createOrUpdateUser logic and eliminate race conditionThe CRUD functions are correct and well-structured. The
createOrUpdateUserfunction implements the intended "update lastSignedInDate or create" behavior, but currently uses afindUserByProvenanceId+ conditionalcreate/updatesequence that creates a small race window: two concurrent logins for a new user could both see "no record" and attemptcreate, relying on the unique constraint and caller error handling.Prisma 6.19.0 (in use here) supports
upsertnatively. SinceuserProvenanceIdis marked@uniquein the schema, you could replace the explicit find-then-create/update pattern with a singleprisma.user.upsertcall keyed onuserProvenanceId. This would:
- Eliminate the race window entirely (atomic at the database level when criteria are met)
- Reduce two DB round-trips to one
Example pattern:
return await prisma.user.upsert({ where: { userProvenanceId: input.userProvenanceId }, update: { role: input.role, lastSignedInDate: new Date() }, create: { /* all fields from input */ } });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
libs/account/package.json(2 hunks)libs/account/src/repository/model.ts(1 hunks)libs/account/src/repository/query.test.ts(1 hunks)libs/account/src/repository/query.ts(1 hunks)libs/auth/src/pages/cft-callback/index.test.ts(8 hunks)libs/auth/src/pages/cft-callback/index.ts(2 hunks)libs/auth/src/pages/sso-callback/index.test.ts(1 hunks)libs/auth/src/pages/sso-callback/index.ts(2 hunks)tsconfig.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tsconfig.json
🧰 Additional context used
🧬 Code graph analysis (4)
libs/account/src/repository/query.test.ts (2)
libs/account/src/repository/model.ts (1)
User(1-8)libs/account/src/repository/query.ts (5)
createUser(4-16)findUserByProvenanceId(18-22)findUserByEmail(24-28)updateUser(30-38)createOrUpdateUser(40-53)
libs/auth/src/pages/cft-callback/index.ts (2)
libs/account/src/repository/query.ts (1)
createOrUpdateUser(40-53)libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
trackException(11-22)
libs/account/src/repository/query.ts (1)
libs/account/src/repository/model.ts (2)
User(1-8)UpdateUserInput(10-13)
libs/auth/src/pages/sso-callback/index.ts (2)
libs/account/src/repository/query.ts (1)
createOrUpdateUser(40-53)libs/cloud-native-platform/src/monitoring/track-exception.ts (1)
trackException(11-22)
🔇 Additional comments (1)
libs/account/src/repository/query.test.ts (1)
1-323: Comprehensive and precise coverage for the user repositoryThese tests thoroughly exercise all repository functions, including optional fields and the different
createOrUpdateUserbranches, and verify the exact Prisma call shapes. The mocking pattern for@hmcts/postgresand subsequent use ofprismalooks appropriate for this setup.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/account/package.json (1)
10-13: Addtypesdeclaration to the subpath export for better TypeScript support.The new
./repository/queryexport is missing atypesfield, which is a best practice for TypeScript modules. Without it, TypeScript consumers may not properly resolve types when importing from this subpath.Apply this diff to add the
typesfield:"./repository/query": { + "types": "./dist/repository/query.d.ts", "production": "./dist/repository/query.js", "default": "./src/repository/query.ts" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/account/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: E2E Tests
3 participants
Jira link
https://tools.hmcts.net/jira/browse/VIBE-143
Change description
Add user table in database and populate it when user is logged in.
Summary by CodeRabbit
New Features
Improvements
Tests
✏️ Tip: You can customize this high-level summary in your review settings.