Skip to content

FIX #2295: Warn when user reloads modified model #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubnemo merged 6 commits into from
Jan 7, 2025
+65 −1
Merged

FIX #2295: Warn when user reloads modified model #2306

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f32e517
FIX #2295: Warn when user reloads modified model
Jan 6, 2025
e9d8b30
Fix typo in test
Jan 6, 2025
50aea9d
First set of addressing review
Jan 7, 2025
f261184
Test repeated invocation on peft model
Jan 7, 2025
8c2f941
Add comment to explain usage of direct addr.
Jan 7, 2025
8145b71
Run maek style
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run maek style
  • Loading branch information
nemo committed Jan 7, 2025
commit 8145b7116a134b6d2a1fb4b4c20f59cdae911466
3 changes: 2 additions & 1 deletion tests/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
import pytest
import torch

from peft import get_peft_model, LoraConfig
from peft import LoraConfig, get_peft_model


class TestGetPeftModel:
RELOAD_WARNING_EXPECTED_MATCH = r"You are trying to modify a model .*"
Expand Down
Loading