Skip to content

FIX #2295: Warn when user reloads modified model #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubnemo merged 6 commits into from
Jan 7, 2025
Merged

FIX #2295: Warn when user reloads modified model #2306

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f32e517
FIX #2295: Warn when user reloads modified model
Jan 6, 2025
e9d8b30
Fix typo in test
Jan 6, 2025
50aea9d
First set of addressing review
Jan 7, 2025
f261184
Test repeated invocation on peft model
Jan 7, 2025
8c2f941
Add comment to explain usage of direct addr.
Jan 7, 2025
8145b71
Run maek style
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in test
  • Loading branch information
nemo committed Jan 6, 2025
commit e9d8b30faec6fdc4dc5749e3731b2508bb01e8d3
2 changes: 1 addition & 1 deletion tests/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_get_peft_model_warns_when_reloading_model(self, get_peft_model, lora_co
with pytest.warns(UserWarning, match=self.RELOAD_WARNING_EXPECTED_MATCH):
get_peft_model(base_model, lora_config)
Copy link
Member

@BenjaminBossan BenjaminBossan Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also adding a check where the user calls get_peft_model on the PeftModel instance itself?


def test_get_peft_model_proposed_fix_in_warning_help(self, get_peft_model, lora_config, base_model, recwarn):
def test_get_peft_model_proposed_fix_in_warning_helps(self, get_peft_model, lora_config, base_model, recwarn):
peft_model = get_peft_model(base_model, lora_config)
peft_model.unload()
get_peft_model(base_model, lora_config)
Expand Down
Loading