FIX Failing target_parameters param usage count#2676
Merged
BenjaminBossan merged 4 commits intohuggingface:mainfrom Jul 30, 2025
Conversation
For testing target_parameters, we use a tiny Llama4 model. This model was refactored in huggingface/transformers#39501, resulting in one parameter being accessed an additional time: https://github.com/huggingface/transformers/pull/39501/files#diff-e668ec07f78afdb2cb805d939e47453757f0b9437436cb860fcb7cb2431c9cf5R69 Therefore, a unit test that relied on how often this parameter was accessed started failing. This PR updates the count to the correct number. Additionally debug print statements that were accidentally left over are now removed.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Note: MacOS tests are failing for unrelated reasons due to a change in transformers that impacts torch <= 2.3. This has been reported. |
githubnemo
approved these changes
Jul 30, 2025
Collaborator
githubnemo
left a comment
githubnemo
left a comment
There was a problem hiding this comment.
Thanks for investigating and the fix, LGTM
BenjaminBossan
deleted the
fix-failing-target-parameter-test-after-transformers-change-llama4
branch
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
) * added reward weights for multi-reward runs in GRPO * reward_weights are float, moved from GRPOTrainer to GRPOConfig * minor comment fix * minor * fix test * missing link --------- Co-authored-by: Quentin Gallouédec <quentin.gallouedec@huggingface.co> Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing
target_parameters, we use a tiny Llama4 model. This model was refactored inhuggingface/transformers#39501, resulting in one parameter being accessed an additional time:
https://github.com/huggingface/transformers/pull/39501/files#diff-e668ec07f78afdb2cb805d939e47453757f0b9437436cb860fcb7cb2431c9cf5R69
(to doublle-check: bad commit:
300d42a43eb3804002b841a389637ceb99a081bb, good commit:abaa043d60edfd0eae78b7a0474aad8e5e433bda)Therefore, a unit test that relied on how often this parameter was accessed started failing. This PR updates the count to the correct number.
Additionally changes:
tests/test_target_parameters.py::TestDecoderModelsTargetParameters::test_disable_adapteron Windows, not sure why