Skip to content

FIX Failing target_parameters param usage count #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminBossan merged 4 commits into from
Jul 30, 2025
Merged

FIX Failing target_parameters param usage count #2676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27860c7
FIX Failing target_parameters param usage count
BenjaminBossan Jul 28, 2025
b07bcd8
Loosen tolerance for Windows in one test
BenjaminBossan Jul 28, 2025
aa47177
Try slightly tighter tolerances for Windows
BenjaminBossan Jul 28, 2025
f0ff8b6
Re-enable all workflows
BenjaminBossan Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try slightly tighter tolerances for Windows
  • Loading branch information
@BenjaminBossan
BenjaminBossan committed Jul 28, 2025
commit aa47177042365971f14462216e251b1c04aa6d5b
5 changes: 3 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ jobs:
# TODO: remove 'fail-fast' line once timeout issue from the Hub is solved
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
os: ["ubuntu-latest", "macos-13", "windows-latest"]
# FIXME
python-version: ["3.12"]
os: ["windows-latest"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion tests/testing_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,7 @@ def get_output(model):
atol, rtol = 1e-6, 1e-6
if (platform.system() == "Windows") and (model_id == "trl-internal-testing/tiny-Llama4ForCausalLM"):
# for some reason, Windows CI fails with stricter tolerance
atol, rtol = 1e-4, 1e-4
atol, rtol = 1e-5, 1e-5

with peft_model.disable_adapter():
output_peft_disabled = get_output(peft_model)
Expand Down