__callStatic: cache created Enum instances

[danielbeardsley]

Instead of creating a new one each time, cache them.

This only matters if you're creating thousands of these objects.

I've used a small test script:

<?
require './vendor/autoload.php';

class Fast extends MyCLabs\Enum\Enum {
   protected const VALUE_ONE = "one";
   protected const VALUE_TWO = "two";
}

$t = microtime(true);
for ($i = 0; $i < 1000; $i++) {
   Fast::VALUE_ONE();
}
$secondsPerOp = (microtime(true) - $t) / 1000;
var_dump("Microseconds per op: " . $secondsPerOp * 1000000);

Before this change, we were getting about 4us per operation,
after this, we get about 1us per op, a 4X speedup!!

Note: This only matters if you end up constructing thousands of these
objects. We end up using this library extensively and thus end up
incurring more than ten milliseconds per request just for Enum
construction.

[danielbeardsley]

QA 👍

[danielbeardsley]

CC @sterlinghirsh @jarstelfox @zdmitchell

[jarstelfox]

Does this pass psalm? Are you opening up a pull upstream?

[zdmitchell]

CR 🎸

[danielbeardsley]

Does this pass psalm? Are you opening up a pull upstream?

Their whole repo doesn't pass psalm (this pull doesn't affect the number of errors). And yes, I will once we get CR here.

[jarstelfox]

Their whole repo doesn't pass psalm

What that's sad! I added it and made it pass 100% 😢

CR 🌵

[danielbeardsley]

What that's sad! I added it and made it pass 100%

It's possible I'm wrong :-( Looking into it.

[jarstelfox]

Ah it looks like they don't use a composer.lock, psalm had an update. Got smarter. Started failing, no one cared. Lame. CC @danielbeardsley

[danielbeardsley]

Master:

------------------------------
13 errors found
------------------------------

[danielbeardsley]

Amended the commit with psalm comment changes.

[jarstelfox]

CR 🌵

[danielbeardsley]

QA 👍

[sterlinghirsh]

CR ⚡

[jarstelfox]

CR 🌵

[danielbeardsley]

We'll have to change our composer.json to use this repo as a dependency.

[sterlinghirsh]

CR ⚡