Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__callStatic: cache created Enum instances #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
__callStatic: cache created Enum instances #1
Changes from 1 commit
82ec4acfacf0bfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Instead of creating a new one each time, cache them. This only matters if you're creating thousands of these objects. I've used a small test script: <? require './vendor/autoload.php'; class Fast extends MyCLabs\Enum\Enum { protected const VALUE_ONE = "one"; protected const VALUE_TWO = "two"; } $t = microtime(true); for ($i = 0; $i < 1000; $i++) { Fast::VALUE_ONE(); } $secondsPerOp = (microtime(true) - $t) / 1000; var_dump("Microseconds per op: " . $secondsPerOp * 1000000); Before this change, we were getting about 4us per operation, after this, we get about 1us per op, a 4X speedup!! Note: This only matters if you end up constrcuting thousands of these objects. We end up using this library extensively and thus end up incurring more than ten milliseconds per request just for Enum construction.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing