Skip to content

Schedule exception fixes #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Schedule exception fixes #564

merged 1 commit into from
Jun 22, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Apr 23, 2020 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

  • Fetch exception dates in main GraphQL query. This allows us to do better UI-side validation of whether there are duplicate dates in the exceptions.

re #561

@landonreed
fix(editor): fetch exception dates in main GraphQL query
7a6b5cd 
This allows us to do better UI-side validation of whether there are duplicate dates in the
exceptions

re #561
@landonreed landonreed marked this pull request as ready for review June 12, 2020 14:51
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jun 13, 2020
@landonreed landonreed merged commit c0133f0 into dev Jun 22, 2020
@landonreed landonreed deleted the schedule-exception-fixes branch June 22, 2020 21:01
@landonreed landonreed mentioned this pull request Jun 22, 2020
Merged
8 tasks
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

+1 more reviewer

@evansiroky evansiroky evansiroky approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@landonreed landonreed

@binh-dam-ibigroup binh-dam-ibigroup

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landonreed @evansiroky @binh-dam-ibigroup