Skip to content

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Jun 22, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Release attempt contains fixes from #583, #564, #586.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #587 into master will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   44.40%   43.89%   -0.51%     
==========================================
  Files         315      315              
  Lines       17270    17270              
  Branches     5269     5269              
==========================================
- Hits         7669     7581      -88     
- Misses       8380     8443      +63     
- Partials     1221     1246      +25     
Flag Coverage Δ
#end_to_end_tests 44.65% <ø> (-0.65%) ⬇️
#unit_tests 15.80% <100.00%> (ø)
Impacted Files Coverage Δ
lib/editor/actions/editor.js 46.39% <ø> (-3.61%) ⬇️
lib/alerts/util/index.js 22.41% <100.00%> (ø)
lib/editor/actions/active.js 66.86% <0.00%> (-13.38%) ⬇️
lib/common/components/TimezoneSelect.js 87.50% <0.00%> (-12.50%) ⬇️
lib/editor/reducers/data.js 47.09% <0.00%> (-12.21%) ⬇️
lib/editor/components/EditorInput.js 65.68% <0.00%> (-7.11%) ⬇️
lib/editor/util/objects.js 87.23% <0.00%> (-6.39%) ⬇️
lib/editor/util/validation.js 79.14% <0.00%> (-3.75%) ⬇️
lib/editor/components/FeedInfoPanel.js 38.55% <0.00%> (-3.62%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c41c8c...336295d. Read the comment docs.

@landonreed landonreed merged commit 10c5627 into master Jun 22, 2020
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants