feat(alerts): Alert effects (MTC)

[binh-dam-ibigroup]

Checklist

• [na] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
• [na] The description lists all applicable issues this PR seeks to resolve
• [na] The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

This adds two supported service alert effects to the alerts editor (see screenshot):

• No effect
• Accessibility issue

[codecov-commenter]

Codecov Report

Merging #583 into dev will decrease coverage by 22.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              dev     #583       +/-   ##
===========================================
- Coverage   37.82%   15.82%   -22.01%     
===========================================
  Files         315      315               
  Lines       17255    16085     -1170     
  Branches     5267     4894      -373     
===========================================
- Hits         6527     2545     -3982     
- Misses       9315    11556     +2241     
- Partials     1413     1984      +571     

Flag	Coverage Δ
#end_to_end_tests	?
#unit_tests	15.82% <100.00%> (ø)

Impacted Files	Coverage Δ
lib/alerts/util/index.js	22.41% <100.00%> (ø)
lib/manager/components/validation/TripsChart.js	0.00% <0.00%> (-80.40%)	⬇️
...nager/components/validation/ServicePerModeChart.js	0.00% <0.00%> (-78.27%)	⬇️
lib/manager/components/HomeProjectDropdown.js	0.00% <0.00%> (-75.76%)	⬇️
...b/manager/containers/ActiveFeedVersionNavigator.js	0.00% <0.00%> (-70.00%)	⬇️
lib/editor/components/EditorSidebar.js	0.00% <0.00%> (-66.67%)	⬇️
lib/editor/containers/ActiveGtfsEditor.js	0.00% <0.00%> (-66.67%)	⬇️
lib/manager/components/version/VersionDateLabel.js	0.00% <0.00%> (-66.67%)	⬇️
lib/editor/components/EditorInput.js	0.00% <0.00%> (-65.69%)	⬇️
lib/common/util/map-keys.js	25.00% <0.00%> (-65.00%)	⬇️
... and 252 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f79af...217da4c. Read the comment docs.

[landonreed]

This comment is incorrect. These are items added in v2 of GTFS-rt: https://gtfs.org/reference/realtime/v2/#enum-effect

[binh-dam-ibigroup]

Just pushed.

[landonreed]

Looks good, thanks. The comment needs fixing though.

[evansiroky]

Although I like that this has a target of being merged to dev and I think we should be merging to dev for all MTC branches, I'll wait and see if Landon wanted to merge it into some other random MTC branch.

[landonreed]

Blocked from merge. Awaiting merge/deployment on June 17, 2020.

[landonreed]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀