Skip to content

Conversation

evansiroky
Copy link
Contributor

@evansiroky evansiroky commented Jun 12, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

  • Fixes 2 places where completed jobs weren't properly being waited upon. This should improve the reliability of the tests.
  • Adds extra assertions to stop create/update/delete tests
  • fixes isolated testing

@evansiroky evansiroky added the WIP label Jun 12, 2020
@evansiroky evansiroky self-assigned this Jun 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #586 into dev will decrease coverage by 28.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #586       +/-   ##
===========================================
- Coverage   44.40%   15.80%   -28.60%     
===========================================
  Files         315      315               
  Lines       17270    16100     -1170     
  Branches     5269     4896      -373     
===========================================
- Hits         7669     2545     -5124     
- Misses       8380    11570     +3190     
- Partials     1221     1985      +764     
Flag Coverage Δ
#end_to_end_tests ?
#unit_tests 15.80% <ø> (ø)
Impacted Files Coverage Δ
lib/manager/components/validation/TripsChart.js 0.00% <0.00%> (-80.40%) ⬇️
lib/editor/util/objects.js 14.89% <0.00%> (-78.73%) ⬇️
...nager/components/validation/ServicePerModeChart.js 0.00% <0.00%> (-78.27%) ⬇️
lib/manager/components/HomeProjectDropdown.js 0.00% <0.00%> (-75.76%) ⬇️
lib/common/util/map-keys.js 25.00% <0.00%> (-75.00%) ⬇️
lib/editor/components/EditorInput.js 0.00% <0.00%> (-72.79%) ⬇️
lib/editor/components/map/TextPath.js 0.00% <0.00%> (-70.00%) ⬇️
...b/manager/containers/ActiveFeedVersionNavigator.js 0.00% <0.00%> (-70.00%) ⬇️
lib/editor/components/timetable/HeaderCell.js 0.00% <0.00%> (-68.97%) ⬇️
lib/manager/components/DeploymentPreviewButton.js 15.78% <0.00%> (-68.43%) ⬇️
... and 259 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c41c8c...3a3f437. Read the comment docs.

@landonreed landonreed removed their assignment Jun 22, 2020
@landonreed landonreed merged commit 336295d into dev Jun 22, 2020
@landonreed landonreed deleted the e2e-test-fixing-again branch June 22, 2020 21:05
@landonreed landonreed mentioned this pull request Jun 22, 2020
8 tasks
@landonreed
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants