Saga pattern

[besok]

Saga pattern

#438

[iluwatar]

Checkstyle with Google Checks also finds several issues that should be resolved.

[besok]

Checkstyle with Google Checks also finds several issues that should be resolved.

Yes. I see a plugin now. Where can i get checkstyle,xml?
(have taken from prev commit from master)

[iluwatar]

Checkstyle with Google Checks also finds several issues that should be resolved.

Yes. I see a plugin now. Where can i get checkstyle,xml?
(have taken from prev commit from master)

It is the google_checks.xml that is built within Checkstyle. I think if you have installed the Checkstyle plugin to your IDE, it is one of the bundled styles. It's also possible to see the list of findings using the command line. Let me know if you need further help.

[besok]

It is the google_checks.xml that is built within Checkstyle. I think if you have installed the Checkstyle plugin to your IDE, it is one of the bundled styles. It's also possible to see the list of findings using the command line. Let me know if you need further help.

I went to https://github.com/iluwatar/java-design-patterns/wiki/03.-Coding-conventions and installed the maven plugin and put checkstyle.xml taken from prev version - https://github.com/iluwatar/java-design-patterns/tree/1.21.0 and fixed all issues. Do I have anything to sort out?

[iluwatar]

Sorry, that wiki page was not up-to-date. I updated it now. If you really need the Checkstyle xml, you can find it at https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml.

Currently the code in this PR is properly formatted.

[besok]

Sorry, that wiki page was not up-to-date. I updated it now. If you really need the Checkstyle xml, you can find it at https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml.

Currently the code in this PR is properly formatted.

Thanks a million.
It seems i don't have anything to change now.
When you have time, please, have a look and give your comments, please.

[iluwatar]

I'm not sure you're doing the Checkstyle check correctly. For me it reports 82 items in 20 files. Which IDE are you using?

[besok]

Ah, i did not check it with google_checks.xml i did it with Checkstyle.xml taken from https://github.com/iluwatar/java-design-patterns/tree/1.21.0.
Perhaps, they have a difference. I will correct it. Sorry for the misunderstanding.

[iluwatar]

Yes, they are quite different. Please comment when you've done the changes and I'll review.

[besok]

Yes, they are quite different. Please comment when you've done the changes and I'll review.

It seems i have sorted all codestyle fixes

[iluwatar]

Well done @besok 👍 Many thanks for the new pattern!

[besok]

Thanks, @iluwatar.