fix: properly clean up child nodes when deleting Iteration Box#13913
Open
octo-patch wants to merge 2 commits intoinfiniflow:mainfrom
Open
fix: properly clean up child nodes when deleting Iteration Box#13913octo-patch wants to merge 2 commits intoinfiniflow:mainfrom
octo-patch wants to merge 2 commits intoinfiniflow:mainfrom
Conversation
Contributor
|
Which version are you using? I haven't been able to reproduce this problem in the latest code on the main branch. @octo-patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13889
Problem
When an Iteration Box container is deleted (via keyboard Delete/Backspace), child nodes inside it are not properly cleaned up. They remain in the underlying data structure and the exported JSON file, which causes workflow editing instability, inability to link/connect nodes, node/edge rendering failures, and browser console exceptions.
There is also a secondary bug in
deleteIterationNodeById(toolbar delete button): the edge filter uses&&instead of||, so edges connected to child nodes are never removed.Solution
Fix 1:
use-before-delete.tsx— When keyboard deletion triggershandleBeforeDelete, explicitly collect all child nodes (nodes withparentIdmatching the deleted Iteration Box ID) and include them intoBeDeletedNodes.Fix 2:
store.ts—deleteIterationNodeById— Fixed the edge filter from&&to||:Testing