feat(gateway): add MaxRangeRequestFileSize protection #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 60.68% 60.71% +0.03%
==========================================
Files 268 268
Lines 33588 33593 +5
==========================================
+ Hits 20383 20397 +14
+ Misses 11531 11520 -11
- Partials 1674 1676 +2
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
adds Config.MaxRangeRequestFileSize to protect against CDN issues with large file range requests. when set, range requests for files larger than this limit return HTTP 501 with suggestion to use verifiable block requests (application/vnd.ipld.raw). protects against Cloudflare's issue where range requests for files over 5GiB are silently ignored, causing entire file to be returned instead of requested range, leading to excess bandwidth and billing. Closes #856
3 tasks
lidel
force-pushed
the
feat/max-range-request-file-size
branch
from
9bf5946 to
5c16939
Compare
guillaumemichel
approved these changes
Sep 26, 2025
cewood
approved these changes
Sep 26, 2025
|
Should the Shareness tests get updated first? Seems like bad hygiene to run those tests if they aren't of significance here. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Config.MaxRangeRequestFileSize to protect against CDN issues with large file range requests. when set, range requests for files larger than this limit return HTTP 501 with suggestion to use verifiable block requests (application/vnd.ipld.raw).
Intention here is to protect against Cloudflare's issue where range requests for files over 5GiB are silently ignored, causing entire file to be returned instead of requested range, leading to excess bandwidth and billing.
The fix here shouldengage when cloudflare sends very first range request to boxo/gateway backend. The backend is able to detect range request for a file beyond safe size, and refuse responding.