feat: add max-range-request-file-size flag #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds protection against CDN bugs with large file range requests. defaults to 5GiB to prevent Cloudflare from returning entire file instead of requested range, which causes excess bandwidth billing. also fixes bitswap rebroadcast delay type issue uses boxo@5c16939b32e3
lidel
force-pushed
the
feat/max-range-request-file-size
branch
from
713c531 to
e33b8eb
Compare
cewood
reviewed
Sep 26, 2025
updates boxo to latest main branch commit for MaxRangeRequestFileSize support
resolved conflicts by choosing final release versions from main: - boxo v0.35.0 - go-libp2p-kad-dht v0.35.0 - go.yaml.in/yaml/v2 v2.4.3
|
https://github.com/ipshipyard/waterworks-infra/pull/765 looking good on staging, moving forward with release to get this to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds protection against CDN bugs with large file range requests. It is disabled by default in boxo/gateway, but for Rainbow, it defaults to 5GiB to prevent Cloudflare from returning entire file instead of requested range, which causes excess bandwidth billing for everyone who is brave enough to run it behind CDN with bugs like this.
cc @cewood @hsanjuan
TODO