fix(provider): call reprovider throughput callback only if reprovide is enabled #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
changed the title
lidel
reviewed
Mar 5, 2025
guillaumemichel
force-pushed
the
fix/reprovide-throughput-callback
branch
from
fd1b777 to
89f7027
Compare
guillaumemichel
force-pushed
the
fix/reprovide-throughput-callback
branch
from
89f7027 to
0171000
Compare
gammazero
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ipfs/kubo#10714
shouldReprovidedoesn't test whether thereprovideIntervalis0, and instructs to reprovide even when it shouldn't.