Skip to content

fix(provider): call reprovider throughput callback only if reprovide is enabled #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025
Merged

fix(provider): call reprovider throughput callback only if reprovide is enabled #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff310ae
fix: only call reprovider throughput callback if reprovide is enabled
guillaumemichel Mar 5, 2025
12b3a49
changelog
guillaumemichel Mar 5, 2025
0171000
fix: shouldReprovide
guillaumemichel Mar 6, 2025
f90e238
Merge branch 'main' into fix/reprovide-throughput-callback
gammazero Mar 11, 2025
7ea5842
Merge branch 'main' into fix/reprovide-throughput-callback
gammazero Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ The following emojis are used to highlight certain changes:

### Changed

- fix(`provider`): don't reprovide if `reprovideInterval` is set to 0 [#871](https://github.com/ipfs/boxo/pull/871)

### Removed

### Fixed
Expand Down
5 changes: 5 additions & 0 deletions provider/reprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ type reprovider struct {
closewg sync.WaitGroup
mu sync.Mutex

// reprovideInterval is the time between 2 reprovides. A value of 0 means
// that no automatic reprovide will be performed.
reprovideInterval time.Duration
initalReprovideDelay time.Duration
initialReprovideDelaySet bool
Expand Down Expand Up @@ -533,6 +535,9 @@ func (s *reprovider) getLastReprovideTime() (time.Time, error) {
}

func (s *reprovider) shouldReprovide() bool {
if s.reprovideInterval == 0 {
return false
}
t, err := s.getLastReprovideTime()
if err != nil {
log.Debugf("getting last reprovide time failed: %s", err)
Expand Down
Loading