fix: enforce identity CID size limits #10949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validate --inline-limit against verifcid.MaxDigestSize - add error when --hash=identity exceeds size limit - add tests for identity CID overflow scenarios - update help text to show maximum inline limit This prevents creation of unbounded identity CIDs by enforcing the 128-byte limit defined in verifcid.MaxDigestSize. Fixes #6011
lidel
force-pushed
the
feat/identity-cid-size-limits
branch
from
eda9f67 to
f3a5642
Compare
- replace deprecated ErrBelowMinimumHashLength with ErrDigestTooSmall - update sharness test error messages to match new sentinel errors
- replace hardcoded 128 byte limit with named constant - improve code clarity and maintainability - align with boxo verifcid package updates
- document --inline-limit enforcement using DefaultMaxIdentityDigestSize - note ipfs files write fixes for codec preservation and raw node support - highlight identity CID overflow prevention
- update test to match actual error message format - remove unnecessary empty line in files.go
highlight that identity CIDs were an experimental feature that was easy to misuse and could become an anti-pattern without proper limits
correct claim that --hash=identity auto-switches to SHA-256; it errors instead
|
Merged ipfs/boxo#1018 and switched this PR to latest boxo@main. Once CI is green, ok to squash-merge I think, and include in 0.38 RC1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Feedback on the default in that PR would be appreciated – it will likely act as ecosystem-wide lowest-common-denominator.
This PR fixes #6011:
--inline-limitagainst verifcid.MaxDigestSize--hash=identityexceeds size limitThis prevents creation of unbounded identity CIDs by enforcing the 128-byte limit defined in
verifcid+ automatically switches to non-identity once limit is reached.