Skip to content

fix: enforce identity CID size limits #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidel merged 11 commits into from
Sep 9, 2025
+345 −15
Merged

fix: enforce identity CID size limits #10949

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f3a5642
fix: enforce identity CID size limits
lidel Aug 29, 2025
2695755
fix: update to use new verifcid sentinel errors
lidel Aug 30, 2025
f915117
refactor: use verifcid.DefaultMaxIdentityDigestSize constant
lidel Aug 30, 2025
b3bac62
docs: add v0.38 changelog highlights
lidel Aug 30, 2025
163b0b8
test: fix identity CID test assertion
lidel Sep 2, 2025
a48d152
docs: changelog
lidel Sep 2, 2025
af1cc5d
chore: latest boxo#1018
lidel Sep 9, 2025
2b0b43c
merge: origin/master keeping boxo#1018
lidel Sep 9, 2025
d0ae0d9
docs: clarify identity CIDs as experimental optimization
lidel Sep 9, 2025
aa776fa
chore: boxo@main
lidel Sep 9, 2025
d11f151
docs: fix changelog accuracy for identity CID behavior
lidel Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix identity CID test assertion 
- update test to match actual error message format
- remove unnecessary empty line in files.go
  • Loading branch information
@lidel
lidel committed Sep 2, 2025
commit 163b0b8c35d1acef523daa5a79778560829c0376
1 change: 0 additions & 1 deletion core/commands/files.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,7 +1366,6 @@ func getPrefixNew(req *cmds.Request) (cid.Builder, error) {
if !ok {
return nil, fmt.Errorf("unrecognized hash function: %s", strings.ToLower(hashFunStr))
}

prefix.MhType = hashFunCode
prefix.MhLength = -1
}
Expand Down
2 changes: 1 addition & 1 deletion docs/examples/kubo-as-a-library/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ go 1.25
replace github.com/ipfs/kubo => ./../../..

require (
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53
github.com/ipfs/kubo v0.0.0-00010101000000-000000000000
github.com/libp2p/go-libp2p v0.43.0
github.com/multiformats/go-multiaddr v0.16.1
Expand Down
4 changes: 2 additions & 2 deletions docs/examples/kubo-as-a-library/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,8 @@ github.com/ipfs-shipyard/nopfs/ipfs v0.25.0 h1:OqNqsGZPX8zh3eFMO8Lf8EHRRnSGBMqcd
github.com/ipfs-shipyard/nopfs/ipfs v0.25.0/go.mod h1:BxhUdtBgOXg1B+gAPEplkg/GpyTZY+kCMSfsJvvydqU=
github.com/ipfs/bbloom v0.0.4 h1:Gi+8EGJ2y5qiD5FbsbpX/TMNcJw8gSqr7eyjHa4Fhvs=
github.com/ipfs/bbloom v0.0.4/go.mod h1:cS9YprKXpoZ9lT0n/Mw/a6/aFV6DTjTLYHeA+gyqMG0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9 h1:p8YZ6IaH9jB9oMbgbAug/DNOSh/YpHLcqe8z3qQFMo0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53 h1:Vzxu8WxN7feiFLzLBuiogktGvuaxhvqiQXjtDtFo2Ow=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/go-bitfield v1.1.0 h1:fh7FIo8bSwaJEh6DdTWbCeZ1eqOaOkKFI74SCnsWbGA=
github.com/ipfs/go-bitfield v1.1.0/go.mod h1:paqf1wjq/D2BBmzfTVFlJQ9IlFOZpg422HL0HqsGWHU=
github.com/ipfs/go-block-format v0.0.3/go.mod h1:4LmD4ZUw0mhO+JSKdpWwrzATiEfM7WWgQ8H5l6P8MVk=
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ require (
github.com/hashicorp/go-version v1.7.0
github.com/ipfs-shipyard/nopfs v0.0.14
github.com/ipfs-shipyard/nopfs/ipfs v0.25.0
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53
github.com/ipfs/go-block-format v0.2.2
github.com/ipfs/go-cid v0.5.0
github.com/ipfs/go-cidutil v0.1.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ github.com/ipfs-shipyard/nopfs/ipfs v0.25.0 h1:OqNqsGZPX8zh3eFMO8Lf8EHRRnSGBMqcd
github.com/ipfs-shipyard/nopfs/ipfs v0.25.0/go.mod h1:BxhUdtBgOXg1B+gAPEplkg/GpyTZY+kCMSfsJvvydqU=
github.com/ipfs/bbloom v0.0.4 h1:Gi+8EGJ2y5qiD5FbsbpX/TMNcJw8gSqr7eyjHa4Fhvs=
github.com/ipfs/bbloom v0.0.4/go.mod h1:cS9YprKXpoZ9lT0n/Mw/a6/aFV6DTjTLYHeA+gyqMG0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9 h1:p8YZ6IaH9jB9oMbgbAug/DNOSh/YpHLcqe8z3qQFMo0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53 h1:Vzxu8WxN7feiFLzLBuiogktGvuaxhvqiQXjtDtFo2Ow=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/go-bitfield v1.1.0 h1:fh7FIo8bSwaJEh6DdTWbCeZ1eqOaOkKFI74SCnsWbGA=
github.com/ipfs/go-bitfield v1.1.0/go.mod h1:paqf1wjq/D2BBmzfTVFlJQ9IlFOZpg422HL0HqsGWHU=
github.com/ipfs/go-block-format v0.0.3/go.mod h1:4LmD4ZUw0mhO+JSKdpWwrzATiEfM7WWgQ8H5l6P8MVk=
Expand Down
4 changes: 2 additions & 2 deletions test/cli/identity_cid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ func TestIdentityCIDOverflowProtection(t *testing.T) {

res := node.RunIPFS("add", "--hash=identity", tempFile)
assert.NotEqual(t, 0, res.ExitErr.ExitCode())
// should error with identity digest too large message
assert.Contains(t, res.Stderr.String(), "identity digest too large")
// should error with digest too large message
assert.Contains(t, res.Stderr.String(), "digest too large")
})

t.Run("ipfs add --inline with valid --inline-limit succeeds", func(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion test/dependencies/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ require (
github.com/huin/goupnp v1.3.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/ipfs/bbloom v0.0.4 // indirect
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9 // indirect
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53 // indirect
github.com/ipfs/go-bitfield v1.1.0 // indirect
github.com/ipfs/go-block-format v0.2.2 // indirect
github.com/ipfs/go-cid v0.5.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions test/dependencies/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2
github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
github.com/ipfs/bbloom v0.0.4 h1:Gi+8EGJ2y5qiD5FbsbpX/TMNcJw8gSqr7eyjHa4Fhvs=
github.com/ipfs/bbloom v0.0.4/go.mod h1:cS9YprKXpoZ9lT0n/Mw/a6/aFV6DTjTLYHeA+gyqMG0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9 h1:p8YZ6IaH9jB9oMbgbAug/DNOSh/YpHLcqe8z3qQFMo0=
github.com/ipfs/boxo v0.34.1-0.20250830162938-3025889071e9/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53 h1:Vzxu8WxN7feiFLzLBuiogktGvuaxhvqiQXjtDtFo2Ow=
github.com/ipfs/boxo v0.34.1-0.20250902010009-373354403a53/go.mod h1:rXql6ncaLZZfLqDG3Cuw9ZYQKd3rMU5bk1TGXF0+ZL0=
github.com/ipfs/go-bitfield v1.1.0 h1:fh7FIo8bSwaJEh6DdTWbCeZ1eqOaOkKFI74SCnsWbGA=
github.com/ipfs/go-bitfield v1.1.0/go.mod h1:paqf1wjq/D2BBmzfTVFlJQ9IlFOZpg422HL0HqsGWHU=
github.com/ipfs/go-block-format v0.2.2 h1:uecCTgRwDIXyZPgYspaLXoMiMmxQpSx2aq34eNc4YvQ=
Expand Down
Loading