Skip to content

Conversation

@Cyclam
Copy link
Collaborator

@Cyclam Cyclam commented Oct 11, 2023

Additional changes required to work with the 2023-09-01 API.

Reviewing is probably easiest commit by commit. Here they are, with commentary where it might be useful:

Testing

Tested CNF and VNF workflow, including SNS create.

@Cyclam Cyclam requested a review from sunnycarter as a code owner October 11, 2023 11:04
@Cyclam Cyclam changed the base branch from achurchard/regenerate-python-sdk to achurchard/label-input-files-as-nsd-or-nfd-repsectively October 11, 2023 13:07
@Cyclam Cyclam changed the base branch from achurchard/label-input-files-as-nsd-or-nfd-repsectively to achurchard/regenerate-python-sdk October 11, 2023 13:07
Copy link
Collaborator

@jamiedparsons jamiedparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a couple of very minor comments.

@Cyclam Cyclam merged commit db638dd into achurchard/regenerate-python-sdk Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants