Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c69d31e
Update bicep templates to use 2023-09-01
Sep 26, 2023
4131b8a
Update metaschema
Sep 26, 2023
4ec885a
Add SDK generation instructions to development.md
Sep 27, 2023
e515ff1
Add Allow-Publisher to required feature flags
Sep 27, 2023
c5ea317
Merge branch 'add-aosm-extension' into andy/general-update-for-2023-0…
Sep 27, 2023
ca183a5
Doc string tidy up
Sep 28, 2023
9da3ea9
Update to published API (which excludes proxy publisher)
Sep 28, 2023
e325e51
Back out proxy publisher for _get_nfdv()
Sep 28, 2023
adfd3ed
Fix tests now proxy publisher has gone
Sep 29, 2023
97c75eb
Add running test help source to development.md
Sep 29, 2023
1712c5f
move live tests to uaenorth
Sep 29, 2023
56f356d
Build wheel for 2023-09-01 CLI extension
Oct 2, 2023
bf60729
Update nf_template.bicep.j2 to use new NFDV resource reference property
Oct 11, 2023
1fcef4d
Add configurationType=Secret to nf_template
Oct 12, 2023
e62fe85
Change publisher scope in nf_template to subscription
Oct 16, 2023
6069017
use secretDeploymentValues for secrets
Oct 17, 2023
e821f12
Fix publisher resource group reference
Oct 17, 2023
526e967
Include publisher SystemAssigned identity
Oct 17, 2023
900cfaf
Use secure objects for deployment parameters
Jamieparsons Oct 17, 2023
8984abc
Bug fix
Jamieparsons Oct 17, 2023
d5cbe76
Markup
Oct 17, 2023
664946a
Merge branch 'andy/general-update-for-2023-09-01' of github.com:jddar…
Oct 17, 2023
836845e
Merge branch 'achurchard/regenerate-python-sdk' into andy/general-upd…
Oct 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update bicep templates to use 2023-09-01
  • Loading branch information
Andy Churchard committed Sep 26, 2023
commit c69d31e3177c5e14b181384acee18c56b855fe73
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@
// This file creates an Artifact Manifest for a CNF
param location string
@description('Name of an existing publisher, expected to be in the resource group where you deploy the template')
param publisherName string
param publisherName string
@description('Name of an existing ACR-backed Artifact Store, deployed under the publisher.')
param acrArtifactStoreName string
@description('Name of the manifest to deploy for the ACR-backed Artifact Store')
param acrManifestName string

// Created by the az aosm definition publish command before the template is deployed
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// Created by the az aosm definition publish command before the template is deployed
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

resource acrArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-04-01-preview' = {
resource acrArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-09-01' = {
parent: acrArtifactStore
name: acrManifestName
location: location
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@ param nfDefinitionGroup string
param nfDefinitionVersion string

// Created by the az aosm definition publish command before the template is deployed
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// Created by the az aosm definition publish command before the template is deployed
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

// Created by the az aosm definition publish command before the template is deployed
resource nfdg 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups@2023-04-01-preview' existing = {
resource nfdg 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups@2023-09-01' existing = {
parent: publisher
name: nfDefinitionGroup
}

resource nfdv 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups/networkfunctiondefinitionversions@2023-04-01-preview' = {
resource nfdv 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups/networkfunctiondefinitionversions@2023-09-01' = {
parent: nfdg
name: nfDefinitionVersion
location: location
Expand All @@ -43,7 +43,7 @@ resource nfdv 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroup
networkFunctionType: 'ContainerizedNetworkFunction'
networkFunctionTemplate: {
nfviType: 'AzureArcKubernetes'
networkFunctionApplications: [
networkFunctionApplications: [
{%- for configuration in nf_application_configurations %}
{
artifactType: 'HelmPackage'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Copyright (c) Microsoft Corporation.

// This file creates an NF definition for a VNF
param location string
param location string
@description('Name of an existing publisher, expected to be in the resource group where you deploy the template')
param publisherName string
param publisherName string
@description('Name of an existing ACR-backed Artifact Store, deployed under the publisher.')
param acrArtifactStoreName string
@description('Name of an existing Storage Account-backed Artifact Store, deployed under the publisher.')
Expand All @@ -20,24 +20,24 @@ param vhdVersion string
param armTemplateVersion string

// Created by the az aosm definition publish command before the template is deployed
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// Created by the az aosm definition publish command before the template is deployed
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

// Created by the az aosm definition publish command before the template is deployed
resource saArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource saArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: saArtifactStoreName
}

resource saArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-04-01-preview' = {
resource saArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-09-01' = {
parent: saArtifactStore
name: saManifestName
location: location
Expand All @@ -52,7 +52,7 @@ resource saArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/a
}
}

resource acrArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-04-01-preview' = {
resource acrArtifactManifest 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-09-01' = {
parent: acrArtifactStore
name: acrManifestName
location: location
Expand Down
12 changes: 6 additions & 6 deletions src/aosm/azext_aosm/generate_nfd/templates/vnfdefinition.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This file creates an NF definition for a VNF
param location string
@description('Name of an existing publisher, expected to be in the resource group where you deploy the template')
param publisherName string
param publisherName string
@description('Name of an existing ACR-backed Artifact Store, deployed under the publisher.')
param acrArtifactStoreName string
@description('Name of an existing Storage Account-backed Artifact Store, deployed under the publisher.')
Expand All @@ -20,30 +20,30 @@ param vhdVersion string
param armTemplateVersion string

// Created by the az aosm definition publish command before the template is deployed
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// Created by the az aosm definition publish command before the template is deployed
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

// Created by the az aosm definition publish command before the template is deployed
resource saArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource saArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: saArtifactStoreName
}

// Created by the az aosm definition publish command before the template is deployed
resource nfdg 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups@2023-04-01-preview' existing = {
resource nfdg 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups@2023-09-01' existing = {
parent: publisher
name: nfDefinitionGroup
}

resource nfdv 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups/networkfunctiondefinitionversions@2023-04-01-preview' = {
resource nfdv 'Microsoft.Hybridnetwork/publishers/networkfunctiondefinitiongroups/networkfunctiondefinitionversions@2023-09-01' = {
parent: nfdg
name: nfDefinitionVersion
location: location
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This file creates an Artifact Manifest for a NSD
param location string
@description('Name of an existing publisher, expected to be in the resource group where you deploy the template')
param publisherName string
param publisherName string
@description('Name of an existing ACR-backed Artifact Store, deployed under the publisher.')
param acrArtifactStoreName string
@description('Name of the manifest to deploy for the ACR-backed Artifact Store')
Expand All @@ -13,17 +13,17 @@ param armTemplateNames array
@description('The version that you want to name the NFM template artifact, in format A.B.C. e.g. 6.13.0. If testing for development, you can use any numbers you like.')
param armTemplateVersion string

resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

resource acrArtifactManifests 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-04-01-preview' = [for (values, i) in armTemplateNames: {
resource acrArtifactManifests 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-09-01' = [for (values, i) in armTemplateNames: {
parent: acrArtifactStore
name: acrManifestNames[i]
location: location
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Highly Confidential Material
//
// The template that the NSD invokes to create the Network Function from a published NFDV.
// The template that the NSD invokes to create the Network Function from a published NFDV.

@description('Publisher where the NFD is published')
param publisherName string = '{{publisher_name}}'
Expand Down Expand Up @@ -40,7 +40,7 @@ var identityObject = (managedIdentity == '') ? {
}
}

resource nf_resource 'Microsoft.HybridNetwork/networkFunctions@2023-04-01-preview' = [for (values, i) in deploymentParameters: {
resource nf_resource 'Microsoft.HybridNetwork/networkFunctions@2023-09-01' = [for (values, i) in deploymentParameters: {
name: '{{network_function_name}}${i}'
location: location
identity: identityObject
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,29 @@ param nsDesignVersion string
param nfviSiteName string = '{{nfvi_site_name}}'

// The publisher resource is the top level AOSM resource under which all other designer resources
// are created.
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
// are created.
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// The artifact store is the resource in which all the artifacts required to deploy the NF are stored.
// The artifact store is the resource in which all the artifacts required to deploy the NF are stored.
// The artifact store is created by the az aosm CLI before this template is deployed.
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

// Created up-front, the NSD Group is the parent resource under which all NSD versions will be created.
resource nsdGroup 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups@2023-04-01-preview' existing = {
resource nsdGroup 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups@2023-09-01' existing = {
parent: publisher
name: nsDesignGroup
}

// The configuration group schema defines the configuration required to deploy the NSD. The NSD references this object in the
// `configurationgroupsSchemaReferences` and references the values in the schema in the `parameterValues`.
// The operator will create a config group values object that will satisfy this schema.
resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@2023-04-01-preview' = {
resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@2023-09-01' = {
parent: publisher
name: '{{cg_schema_name}}'
location: location
Expand All @@ -50,7 +50,7 @@ resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@
}

// The NSD version
resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups/networkservicedesignversions@2023-04-01-preview' = {
resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups/networkservicedesignversions@2023-09-01' = {
parent: nsdGroup
name: nsDesignVersion
location: location
Expand Down Expand Up @@ -102,7 +102,7 @@ resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngrou
updateDependsOn: []
}
}
{%- endfor %}
{%- endfor %}
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This file creates an Artifact Manifest for a NSD
param location string
@description('Name of an existing publisher, expected to be in the resource group where you deploy the template')
param publisherName string
param publisherName string
@description('Name of an existing ACR-backed Artifact Store, deployed under the publisher.')
param acrArtifactStoreName string
@description('Name of the manifest to deploy for the ACR-backed Artifact Store')
Expand All @@ -13,17 +13,17 @@ param armTemplateNames array
@description('The version that you want to name the NFM template artifact, in format A.B.C. e.g. 6.13.0. If testing for development, you can use any numbers you like.')
param armTemplateVersion string

resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

resource acrArtifactManifests 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-04-01-preview' = [for (values, i) in armTemplateNames: {
resource acrArtifactManifests 'Microsoft.Hybridnetwork/publishers/artifactStores/artifactManifests@2023-09-01' = [for (values, i) in armTemplateNames: {
parent: acrArtifactStore
name: acrManifestNames[i]
location: location
Expand All @@ -36,4 +36,4 @@ resource acrArtifactManifests 'Microsoft.Hybridnetwork/publishers/artifactStores
}
]
}
}]
}]
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,29 @@ param nsDesignVersion string
param nfviSiteName string = 'ubuntu_NFVI'

// The publisher resource is the top level AOSM resource under which all other designer resources
// are created.
resource publisher 'Microsoft.HybridNetwork/publishers@2023-04-01-preview' existing = {
// are created.
resource publisher 'Microsoft.HybridNetwork/publishers@2023-09-01' existing = {
name: publisherName
scope: resourceGroup()
}

// The artifact store is the resource in which all the artifacts required to deploy the NF are stored.
// The artifact store is the resource in which all the artifacts required to deploy the NF are stored.
// The artifact store is created by the az aosm CLI before this template is deployed.
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-04-01-preview' existing = {
resource acrArtifactStore 'Microsoft.HybridNetwork/publishers/artifactStores@2023-09-01' existing = {
parent: publisher
name: acrArtifactStoreName
}

// Created up-front, the NSD Group is the parent resource under which all NSD versions will be created.
resource nsdGroup 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups@2023-04-01-preview' existing = {
resource nsdGroup 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups@2023-09-01' existing = {
parent: publisher
name: nsDesignGroup
}

// The configuration group schema defines the configuration required to deploy the NSD. The NSD references this object in the
// `configurationgroupsSchemaReferences` and references the values in the schema in the `parameterValues`.
// The operator will create a config group values object that will satisfy this schema.
resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@2023-04-01-preview' = {
resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@2023-09-01' = {
parent: publisher
name: 'ubuntu_ConfigGroupSchema'
location: location
Expand All @@ -50,7 +50,7 @@ resource cgSchema 'Microsoft.Hybridnetwork/publishers/configurationGroupSchemas@
}

// The NSD version
resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups/networkservicedesignversions@2023-04-01-preview' = {
resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngroups/networkservicedesignversions@2023-09-01' = {
parent: nsdGroup
name: nsDesignVersion
location: location
Expand Down Expand Up @@ -100,7 +100,7 @@ resource nsdVersion 'Microsoft.Hybridnetwork/publishers/networkservicedesigngrou
uninstallDependsOn: []
updateDependsOn: []
}
}
}
]
}
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Highly Confidential Material
//
// The template that the NSD invokes to create the Network Function from a published NFDV.
// The template that the NSD invokes to create the Network Function from a published NFDV.

@description('Publisher where the NFD is published')
param publisherName string = 'jamie-mobile-publisher'
Expand Down Expand Up @@ -35,7 +35,7 @@ var identityObject = (managedIdentity == '') ? {
}
}

resource nf_resource 'Microsoft.HybridNetwork/networkFunctions@2023-04-01-preview' = [for (values, i) in deploymentParameters: {
resource nf_resource 'Microsoft.HybridNetwork/networkFunctions@2023-09-01' = [for (values, i) in deploymentParameters: {
name: 'ubuntu-vm-nfdg${i}'
location: location
identity: identityObject
Expand All @@ -50,4 +50,4 @@ resource nf_resource 'Microsoft.HybridNetwork/networkFunctions@2023-04-01-previe
allowSoftwareUpdate: true
deploymentValues: string(values)
}
}]
}]
Loading