Proposed fix 1/2 for #388 #436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bower and grunt-bower-concat are now required for building json-editor * math.js is now required for running json-editor, but is not checked by jshint * grunt no longer runs jshint on the output dist file, as it may contain external libaries * float comparisons for multipleOf, divisibleBy, maximum, minimum use math.js
|
What about treating math.js as an optional dependency? In the validator, use math.js if it's loaded on the page, otherwise use the existing logic. |
|
@jdorn heads up I'm actually looking at this PR again right now, since the change fails for |
This takes care of e.g. `3.57 multipleOf 0.01`.
|
Modified to now work for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed fix for #388 involves actually including math.js.
Advantages:
Disadvantages: