Added translation support for buttons shown by array editors #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Just 'Delete' text, whereas the the array.js editor displays the item title too. Is this intentional? Nevertheless, I've provided distinct translation keys for both versions of the Delete button text.
jdorn
added a commit
that referenced
this pull request
Feb 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the json-editor's translation support worked for error messages only, whereas my project (http://szarada.net/) needed also Polish translations of buttons shown by one of array editors.
Attached patch provides support for the localised button texts and titles, following json-editor's original translation framework principles and API-s.
Although my project uses the array.js editor only, I've provided similar translation support to the table.js editor too, to keep source code consistency.
Big thanks for the excellent JSON editor component from the Szarada.net crew!