Skip to content

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Nov 18, 2025

Summary

  • Removed biome tests from the aqua backend e2e test suite

Details

The biome project changed its GitHub release tag format from cli/v1.x.x to @biomejs/[email protected] starting with version 2.0.0. The aqua registry configuration doesn't properly handle version 2.0.0 (it tries to use cli/2.0.0 which doesn't exist), and version 2.0.1 has no assets available.

Rather than updating the aqua registry configuration, we're removing the biome test from the test suite for now since other tools adequately test the aqua backend functionality.

Test plan

  • Verified the test passes without the biome tests
  • All other aqua backend tests continue to pass (ripgrep, age, helm, typos, terragrunt)

🤖 Generated with Claude Code


Note

Removes biome tests from the aqua backend e2e script, keeping other checks intact.

  • e2e/backend:
    • Remove biomejs/biome checks from e2e/backend/test_aqua while retaining other tool version assertions and the ls-remote assertion for sharkdp/hyperfine.

Written by Cursor Bugbot for commit 9eb09ff. This will update automatically on new commits. Configure here.

The biome project changed its GitHub release tag format from cli/v1.x.x
to @biomejs/[email protected] starting with version 2.0.0. The aqua registry
configuration doesn't properly handle version 2.0.0 (it tries to use
cli/2.0.0 which doesn't exist), and version 2.0.1 has no assets available.

Rather than updating the aqua registry configuration, we're removing
the biome test from the test suite for now since other tools adequately
test the aqua backend functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings November 18, 2025 02:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes biome tests from the aqua backend e2e test suite due to incompatibility with biome's new versioning scheme. Starting with version 2.0.0, biome changed its GitHub release tag format from cli/v1.x.x to @biomejs/[email protected], which breaks the aqua registry configuration. Rather than updating the registry, these tests are being removed as other tools provide sufficient coverage of aqua backend functionality.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jdx jdx enabled auto-merge (squash) November 18, 2025 02:03
@jdx jdx merged commit 284c7e3 into main Nov 18, 2025
30 checks passed
@jdx jdx deleted the fix-aqua-test-biome branch November 18, 2025 02:13
@github-actions
Copy link

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.11.5 x -- echo 19.4 ± 0.3 18.5 21.9 1.00
mise x -- echo 19.7 ± 0.4 18.7 21.4 1.02 ± 0.03

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.11.5 env 18.9 ± 0.5 17.8 22.9 1.00
mise env 19.3 ± 0.5 18.0 24.8 1.02 ± 0.04

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.11.5 hook-env 19.0 ± 0.6 18.0 25.3 1.00
mise hook-env 19.4 ± 0.5 18.5 21.8 1.02 ± 0.04

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.11.5 ls 16.6 ± 0.4 15.9 20.9 1.00
mise ls 16.9 ± 0.4 15.7 18.8 1.02 ± 0.03

xtasks/test/perf

Command mise-2025.11.5 mise Variance
install (cached) 107ms 109ms -1%
ls (cached) 65ms 65ms +0%
bin-paths (cached) 72ms 72ms +0%
task-ls (cached) 428ms 442ms -3%

jdx pushed a commit that referenced this pull request Nov 18, 2025
### 📦 Registry

- add tbls by @artemklevtsov in
[#6987](#6987)

### 🐛 Bug Fixes

- **(nushell)** add missing `| parse env | update-env` for deactivation
operations by @jokeyrhyme in
[#6994](#6994)
- **(pwsh)** wrap the executable path with double quotes by @leosuncin
in [#6993](#6993)
- in `activate bash` output, wrap mise executable path in single-quotes
by @cspotcode in [#7002](#7002)

### 📚 Documentation

- simplify apt instructions by @scop in
[#6986](#6986)
- update idiomatic version files enablement info by @scop in
[#6985](#6985)

### 🧪 Testing

- **(aqua)** remove biome test due to version incompatibility by @jdx in
[#7000](#7000)

### 📦️ Dependency Updates

- lock file maintenance by @renovate[bot] in
[#6997](#6997)

### New Contributors

- @jokeyrhyme made their first contribution in
[#6994](#6994)
- @cspotcode made their first contribution in
[#7002](#7002)
- @artemklevtsov made their first contribution in
[#6987](#6987)
- @leosuncin made their first contribution in
[#6993](#6993)

## 📦 Aqua Registry Updates

#### New Packages (1)

-
[`houseabsolute/omegasort`](https://github.com/houseabsolute/omegasort)

#### Updated Packages (5)

- [`apache/maven`](https://github.com/apache/maven)
- [`chaqchase/lla`](https://github.com/chaqchase/lla)
- [`leoafarias/fvm`](https://github.com/leoafarias/fvm)
- [`rustic-rs/rustic`](https://github.com/rustic-rs/rustic)
- [`sigstore/rekor`](https://github.com/sigstore/rekor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants