fix: in activate bash output, wrap mise executable path in single-quotes
#7002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the path to
mise.exewill contain backslashes.Both
busybox.exe bashand Git-for-Windows' "Git Bash" can understand these backslash paths.But bash syntax rules dictate that unquoted backslashes are interpreted as escapes. We must wrap the path in single-quotes to avoid this.
Quoting is technically more correct on Linux, too, even though the issues it avoids -- splitting on spaces -- are largely hypothetical.1
I can't think of any way that this code change would break someone's legitimate setup on Linux or Mac.
Footnotes
To be pedantic, if the path to
miseincludes a single-quote -- if the name of a parent directory has a single-quote in it -- then this will be broken on Linux, but it would already be broken before this code change, so we are not making it worse. ↩