Skip to content

fix: in activate bash output, wrap mise executable path in single-quotes #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Nov 18, 2025
Merged

fix: in activate bash output, wrap mise executable path in single-quotes #7002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d981ba
In `activate bash` output, wrap paths to mise executable in single-qu…
cspotcode Nov 18, 2025
14926e9
update snapshot
cspotcode Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/shell/bash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl Shell for Bash {
local command
command="${{1:-}}"
if [ "$#" = 0 ]; then
command {exe}
command '{exe}'
return
fi
shift
Expand All @@ -47,12 +47,12 @@ impl Shell for Bash {
deactivate|shell|sh)
# if argv doesn't contains -h,--help
if [[ ! " $@ " =~ " --help " ]] && [[ ! " $@ " =~ " -h " ]]; then
eval "$(command {exe} "$command" "$@")"
eval "$(command '{exe}' "$command" "$@")"
return $?
fi
;;
esac
command {exe} "$command" "$@"
command '{exe}' "$command" "$@"
}}

_mise_hook() {{
Expand Down Expand Up @@ -85,7 +85,7 @@ impl Shell for Bash {
fi

command_not_found_handle() {{
if [[ "$1" != "mise" && "$1" != "mise-"* ]] && {exe} hook-not-found -s bash -- "$1"; then
if [[ "$1" != "mise" && "$1" != "mise-"* ]] && '{exe}' hook-not-found -s bash -- "$1"; then
_mise_hook
"$@"
elif [ -n "$(declare -f _command_not_found_handle)" ]; then
Expand Down
8 changes: 4 additions & 4 deletions src/shell/snapshots/mise__shell__bash__tests__activate.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ mise() {
local command
command="${1:-}"
if [ "$#" = 0 ]; then
command /some/dir/mise
command '/some/dir/mise'
return
fi
shift
Expand All @@ -23,12 +23,12 @@ mise() {
deactivate|shell|sh)
# if argv doesn't contains -h,--help
if [[ ! " $@ " =~ " --help " ]] && [[ ! " $@ " =~ " -h " ]]; then
eval "$(command /some/dir/mise "$command" "$@")"
eval "$(command '/some/dir/mise' "$command" "$@")"
return $?
fi
;;
esac
command /some/dir/mise "$command" "$@"
command '/some/dir/mise' "$command" "$@"
}

_mise_hook() {
Expand Down Expand Up @@ -77,7 +77,7 @@ if [ -z "${_mise_cmd_not_found:-}" ]; then
fi

command_not_found_handle() {
if [[ "$1" != "mise" && "$1" != "mise-"* ]] && /some/dir/mise hook-not-found -s bash -- "$1"; then
if [[ "$1" != "mise" && "$1" != "mise-"* ]] && '/some/dir/mise' hook-not-found -s bash -- "$1"; then
_mise_hook
"$@"
elif [ -n "$(declare -f _command_not_found_handle)" ]; then
Expand Down
Loading