Skip to content

Conversation

@risu729
Copy link
Contributor

@risu729 risu729 commented Nov 29, 2025

#7138 broke e2e-win/7z.Tests.ps1.

7z2500-extra.7z has a directory structure like:

7z2500-extra$ ls -R
.:
7za.dll  7za.exe  7zxa.dll  Far  License.txt  arm64  history.txt  readme.txt  x64

./Far:
7-ZipEng.hlf  7-ZipEng.lng  7-ZipFar.dll  7-ZipFar64.dll  7-ZipRus.hlf  7-ZipRus.lng  7zToFar.ini  far7z.reg  far7z.txt

./arm64:
7-ZipFar.dll  7za.dll  7za.exe  7zxa.dll

./x64:
7za.dll  7za.exe  7zxa.dll

So if both /arm64 and /x64 are on PATH, /arm64/7za.exe is used even on x64 arch.

This PR fixes this by prioritising the root path if the root path contains an executable file.


Note

Bin path discovery now uses the install root if it contains an executable and recognizes executable-only subdirs; docs updated and e2e adjusted.

  • Backend (GitHub/GitLab unified)
    • src/backend/github.rs bin path discovery:
      • Prefer install root when it contains any executable file.
      • If a subdirectory contains executables directly, treat that subdirectory as a bin path.
  • Docs
    • Update binary path lookup order in docs/dev-tools/backends/github.md and docs/dev-tools/backends/gitlab.md to reflect new root/subdir executable handling.
  • Tests
    • e2e/backend/test_github: add mise uninstall before installs for clean runs.
  • Lockfile
    • Refresh mise.lock with added size/checksum metadata and removed unused entries.

Written by Cursor Bugbot for commit bafd825. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 29, 2025 08:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the binary path discovery logic for GitHub and GitLab backends by prioritizing the root install path when it contains executable files, preventing unnecessary deep directory searches.

Key changes:

  • Added a new check in discover_bin_paths() to detect executables in the root install directory before searching subdirectories
  • Updated documentation for both GitHub and GitLab backends to reflect the new 6-step binary path lookup order

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/backend/github.rs Adds logic to check for executables in the root install path (step 3 in the lookup order), positioned between checking for bin/ directory and searching subdirectories
docs/dev-tools/backends/github.md Updates binary path lookup documentation to include the new step 3 and renumbers subsequent steps
docs/dev-tools/backends/gitlab.md Updates binary path lookup documentation consistently with GitHub backend changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

autofix-ci bot and others added 3 commits November 29, 2025 08:58
The raw file asset test expects to download a different asset
(hello-world) than the previous tests (hello-world-1.0.0.tar.gz).
Since they use the same version (1.0.0), mise skips reinstallation.
Add uninstall before install to ensure the correct asset is downloaded.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@jdx jdx enabled auto-merge (squash) November 30, 2025 01:45
@jdx
Copy link
Owner

jdx commented Nov 30, 2025

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@jdx jdx merged commit 588e828 into jdx:main Nov 30, 2025
31 checks passed
@risu729 risu729 deleted the use-root-as-bin-path branch November 30, 2025 03:24
jdx pushed a commit that referenced this pull request Nov 30, 2025
### 🚀 Features

- **(backend)** add filter_bins option to github/gitlab backends by
@risu729 in [#7105](#7105)
- **(ci)** auto-close PRs from non-maintainers by @jdx in
[#7108](#7108)
- **(conda)** add conda backend for installing packages from conda-forge
by @jdx in [#7139](#7139)
- **(github)** add rename_exe option and switch elm, opam, yt-dlp from
ubi by @jdx in [#7140](#7140)
- **(install)** add --locked flag for strict lockfile mode by @jdx in
[#7098](#7098)
- **(lock)** implement cross-platform lockfile generation by @jdx in
[#7091](#7091)
- **(lockfile)** add options field for tool artifact identity by @jdx in
[#7092](#7092)
- **(lockfile)** add env field and local lockfile support by @jdx in
[#7099](#7099)
- **(lockfile)** add URL support for deno, go, and zig backends by @jdx
in [#7112](#7112)
- **(lockfile)** add URL support for vfox backend by @jdx in
[#7114](#7114)
- **(lockfile)** add multi-platform checksums without downloading
tarballs by @jdx in [#7113](#7113)

### 🐛 Bug Fixes

- **(backend)** allow platform-specific strip_components by @risu729 in
[#7106](#7106)
- **(backend)** prefer path root for bin path if it contains an
executable by @risu729 in [#7151](#7151)
- **(bash)** avoid deactivate error on (no)unset PROMPT_COMMAND by @scop
in [#7096](#7096)
- **(ci)** use updatedAt instead of createdAt for stale PR detection by
@jdx in [#7109](#7109)
- **(github)** search subdirectories for executables in
discover_bin_paths by @jdx in
[#7138](#7138)
- **(lockfile)** combine api_url with asset_pattern for GitHub release
URLs by @jdx in [#7111](#7111)

### 🚜 Refactor

- **(lock)** simplify lockfile to always use array format by @jdx in
[#7093](#7093)
- **(lockfile)** use compact inline table format by @jdx in
[#7141](#7141)

### 📚 Documentation

- **(gitlab)** document rename_exe option also for gitlab backend by
@risu729 in [#7149](#7149)
- **(lockfile)** update documentation for recent lockfile changes by
@jdx in [#7107](#7107)
- **(node)** use config_root in _.path for pnpm example by @risu729 in
[#7146](#7146)
- **(registry)** add github/gitlab backends to the preferred backends
list by @risu729 in [#7148](#7148)
- **(registry)** add url mappings for all backends by @risu729 in
[#7147](#7147)

### 📦️ Dependency Updates

- update docker/metadata-action digest to c299e40 by @renovate[bot] in
[#7101](#7101)
- update ghcr.io/jdx/mise:alpine docker digest to 693c5f6 by
@renovate[bot] in [#7102](#7102)
- update ghcr.io/jdx/mise:deb docker digest to 9985cab by @renovate[bot]
in [#7104](#7104)
- update ghcr.io/jdx/mise:copr docker digest to 564d8e1 by
@renovate[bot] in [#7103](#7103)
- update rust crate ubi to 0.8.4 by @risu729 in
[#7154](#7154)

### 📦 Registry

- add aqua backend as primary for e1s by @jdx in
[#7115](#7115)
- add gem backend for bashly by @jdx in
[6af6607](6af6607)
- switch 1password from asdf to vfox backend by @jdx in
[#7116](#7116)
- add vfox backend for bfs by @jdx in
[#7126](#7126)
- add github backend for btrace by @jdx in
[#7129](#7129)
- add github backend for cf by @jdx in
[#7131](#7131)
- add vfox backend for bpkg by @jdx in
[#7130](#7130)
- switch apollo-ios from asdf to github backend by @jdx in
[#7118](#7118)
- add vfox backend for chromedriver by @jdx in
[#7134](#7134)
- switch superhtml, vespa-cli, xcsift from ubi to github backend by @jdx
in [#7137](#7137)
- add vfox backend for clickhouse by @jdx in
[#7136](#7136)
- switch chicken to vfox plugin by @jdx in
[#7135](#7135)
- switch chezscheme from asdf to vfox backend by @jdx in
[#7132](#7132)
- add vfox backend for carthage by @jdx in
[#7133](#7133)
- switch azure-functions-core-tools from asdf to vfox backend by @jdx in
[#7128](#7128)
- switch aapt2 to vfox backend by @jdx in
[#7117](#7117)
- switch ant to vfox backend by @jdx in
[#7119](#7119)
- switch asciidoctorj from asdf to vfox backend by @jdx in
[#7121](#7121)
- switch awscli-local to pipx backend by @jdx in
[#7120](#7120)
- add omnictl by @risu729 in
[#7145](#7145)
- remove pnpm asdf plugin from fallback by @risu729 in
[#7143](#7143)
- switch tanzu to github backend by @jdx in
[#7124](#7124)
- switch android-sdk to vfox plugin by @jdx in
[#7127](#7127)
- add vfox backend for ag (The Silver Searcher) by @jdx in
[#7122](#7122)

### Chore

- **(registry)** ignore deleted tools in test-tool workflow by @risu729
in [#7081](#7081)
- **(release)** show registry section last in changelog by @jdx in
[#7156](#7156)
- update mise.lock with checksums by @jdx in
[71e9123](71e9123)
- disable cancel-in-progress for test workflow on main branch by
@risu729 in [#7152](#7152)

## 📦 Aqua Registry Updates

#### Updated Packages (1)

- [`orf/gping`](https://github.com/orf/gping)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants