Skip to content

Conversation

@jeertmans
Copy link
Owner

@jeertmans jeertmans commented Oct 24, 2023

This does not work at the moment, because setLoops(1) does not seem to end the current loop. Instead, it finishes the current loop, and plays to more loops before EndOfMedia is reached.

Link to forum topic: https://forum.qt.io/topic/151450/qmediaplayer-setloops-1-finishes-current-loop-and-does-two-more-is-it-normal/2?_=1698233106574.

Closes #254

@jeertmans jeertmans added cli Related to the command line interface present Related to the main "present" feature labels Oct 24, 2023
@jeertmans jeertmans temporarily deployed to github-pages October 24, 2023 06:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/present/__init__.py 72.00% <100.00%> (+0.22%) ⬆️
manim_slides/present/player.py 78.60% <14.28%> (-1.91%) ⬇️

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command line interface present Related to the main "present" feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow to complete loop before going to next slide

2 participants