Skip to content

feat(cli): add next-terminates-loop CLI option #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2023
Merged

feat(cli): add next-terminates-loop CLI option #299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56eee9d
feat(cli): add `next-terminates-loop` CLI option
jeertmans Oct 24, 2023
660ef8b
chore(lib): fix `--next-terminates-loop`
jeertmans Oct 30, 2023
eef9196
chore(CHANGELOG): document changes
jeertmans Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(lib): fix --next-terminates-loop
  • Loading branch information
@jeertmans
jeertmans committed Oct 30, 2023
commit 660ef8b9b87ac32c75baa8666b217c5308715522
4 changes: 2 additions & 2 deletions manim_slides/present/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ def present(
start_at: Tuple[Optional[int], Optional[int], Optional[int]],
start_at_scene_number: int,
start_at_slide_number: int,
screen_number: Optional[int] = None,
playback_rate: float = 1.0,
screen_number: Optional[int],
playback_rate: float,
next_terminates_loop: bool,
) -> None:
"""
Expand Down
4 changes: 4 additions & 0 deletions manim_slides/present/player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ def next(self) -> None:
if self.media_player.playbackState() == QMediaPlayer.PausedState:
self.media_player.play()
elif self.next_terminates_loop and self.media_player.loops() != 1:
position = self.media_player.position()
self.media_player.setLoops(1)
self.media_player.stop()
self.media_player.setPosition(position)
self.media_player.play()
else:
self.load_next_slide()

Expand Down